Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] add alertId parameter in get chained alert API and paginate associated alerts if alertId param is mentioned #1074

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d9f66b3 from #1071.

…d alerts if alertId param is mentioned (#1071)

* add alertId parameter in get chained alert API and paginate associated alerts if alertId param is mentioned

Signed-off-by: Surya Sashank Nistala <[email protected]>

* set from param in associated alerts search request

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit d9f66b3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1074 (6cc5393) into 2.9 (ef8ac16) will decrease coverage by 0.06%.
The diff coverage is 79.16%.

@@             Coverage Diff              @@
##                2.9    #1074      +/-   ##
============================================
- Coverage     67.91%   67.86%   -0.06%     
  Complexity      119      119              
============================================
  Files           160      160              
  Lines         10448    10467      +19     
  Branches       1572     1576       +4     
============================================
+ Hits           7096     7103       +7     
- Misses         2654     2665      +11     
- Partials        698      699       +1     
Files Changed Coverage Δ
...ting/transport/TransportGetWorkflowAlertsAction.kt 67.96% <77.77%> (+1.30%) ⬆️
...lerting/resthandler/RestGetWorkflowAlertsAction.kt 95.55% <83.33%> (-1.95%) ⬇️

... and 7 files with indirect coverage changes

@eirsep eirsep merged commit ca28061 into 2.9 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants