Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use acknowledge alert request,response, actions from common-utils dependencies #607

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e94ea32 from #606

…endencies (#606)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e94ea32)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team October 14, 2022 23:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #607 (cb88de0) into 2.x (de32d93) will decrease coverage by 0.14%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##                2.x     #607      +/-   ##
============================================
- Coverage     76.16%   76.01%   -0.15%     
  Complexity      116      116              
============================================
  Files           127      124       -3     
  Lines          6444     6392      -52     
  Branches        927      926       -1     
============================================
- Hits           4908     4859      -49     
+ Misses         1064     1062       -2     
+ Partials        472      471       -1     
Impacted Files Coverage Δ
...rting/transport/TransportAcknowledgeAlertAction.kt 82.90% <33.33%> (-1.45%) ⬇️
...n/kotlin/org/opensearch/alerting/AlertingPlugin.kt 93.50% <100.00%> (ø)
...alerting/resthandler/RestAcknowledgeAlertAction.kt 93.33% <100.00%> (ø)
...ing/model/destination/DestinationContextFactory.kt 75.00% <0.00%> (-3.58%) ⬇️
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 70.40% <0.00%> (+0.89%) ⬆️
...nationmigration/DestinationMigrationCoordinator.kt 68.08% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit b2eff0f into 2.x Oct 15, 2022
@github-actions github-actions bot deleted the backport/backport-606-to-2.x branch October 15, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants