Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.114.0 #7226

Merged
merged 49 commits into from
Apr 2, 2024
Merged

build: release v6.114.0 #7226

merged 49 commits into from
Apr 2, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 2, 2024

New

  • fix: prefill myinfo dropdown field options when faking sample submission data #7225
  • feat(mrf): attachments #7181
  • fix(mrf): design review add workflow page #7218
  • fix(mrf): skip verifying OTP signatures on decryption for export #7192
  • chore: update mrf copy on create-page #7217
  • refactor: move override code closer to other overrides #7216
  • fix(mrf): remove any response limits for MRF #7214
  • chore(mrf): prevent form activation if email confirmation is present #7201
  • feat: Disabling MRF for Forms with SingPass #7200
  • feat(mrf): backend validation for field locking #7143
  • chore: switch advertising for checkpoint to mrf #7191
  • feat: disabling submit another response button (MRF) #7186
  • chore: remove unused deps #7150
  • build: merge release v6.113.0 back to develop #7149
  • feat: disabling response limit toggle for MRF #7180
  • revert: "chore(deps-dev): bump jest-mock-axios from 4.7.2 to 4.7.3" #7179
  • fix: remove number and decimal scrolling #7171
  • build: release v6.113.0 #7148
  • chore: bump version to v6.114.0 993e31e

Dependencies

  • fix(deps): bump mongodb-memory-server-core from 9.1.6 to 9.1.7 #7211
  • fix(deps): bump aws-sdk from 2.1354.0 to 2.1585.0 #7209
  • fix(deps): bump neverthrow from 6.0.0 to 6.1.0 #7208
  • fix(deps): bump @babel/runtime from 7.22.3 to 7.24.1 #7207
  • fix(deps): bump libphonenumber-js from 1.10.49 to 1.10.59 #7204
  • fix(deps): bump http-status-codes from 2.2.0 to 2.3.0 #7203
  • fix(deps): bump express from 4.18.2 to 4.19.2 #7199
  • fix(deps): bump libphonenumber-js from 1.10.58 to 1.10.59 in /shared #7195
  • fix(deps): bump type-fest from 4.13.1 to 4.14.0 in /shared #7190
  • chore(deps): Upgrade bson from 5.4.0 to 5.5.1 #7152
  • fix(deps): bump type-fest from 4.8.3 to 4.13.1 in /shared #7178
  • fix(deps): bump celebrate from 15.0.1 to 15.0.3 #7175
  • fix(deps): bump zod from 3.22.3 to 3.22.4 #7174
  • fix(deps): bump libphonenumber-js from 1.10.52 to 1.10.58 in /shared #7168
  • fix(deps): bump @faker-js/faker from 8.0.2 to 8.4.1 #7161
  • fix(deps): bump ts-essentials from 9.3.1 to 9.4.1 #7158
  • fix(deps): bump the npm_and_yarn group group with 2 updates #7151
  • chore(deps): bump fast-xml-parser, @aws-sdk/client-secrets-manager and @aws-sdk/client-ssm in /functions/form-payment-reconciliation #6490

Dev-Dependencies

  • chore(deps-dev): bump @babel/core from 7.23.9 to 7.24.3 #7206
  • chore(deps-dev): bump eslint-plugin-playwright from 0.12.0 to 1.5.4 #7189
  • chore(deps-dev): bump express from 4.18.2 to 4.19.2 in /frontend #7198
  • chore(deps-dev): bump rimraf from 4.4.0 to 5.0.5 #7173
  • chore(deps-dev): bump @types/convict from 6.1.1 to 6.1.6 #7176
  • chore(deps-dev): bump ts-node from 10.9.1 to 10.9.2 #7172
  • chore(deps-dev): bump @types/lodash from 4.14.202 to 4.17.0 in /shared #7169
  • chore(deps-dev): bump @types/uuid from 9.0.0 to 9.0.8 #7165
  • chore(deps-dev): bump @types/cookie-parser from 1.4.3 to 1.4.7 #7163
  • chore(deps-dev): bump @opengovsg/mockpass from 4.0.8 to 4.1.0 #7160
  • chore(deps-dev): bump @types/html-escaper from 3.0.0 to 3.0.2 #7159
  • chore(deps-dev): bump @types/busboy from 1.5.0 to 1.5.3 #7157
  • chore(deps-dev): bump jest-mock-axios from 4.7.2 to 4.7.3 #7154

Tests

feat(mrf): attachments #7181

@kathleenkhy

Preparation:

Respondent 1

Respondent 2

  • Attach file 2 (Respondent Update documentation for site banners #2) to field 2
  • Ensure that field 1 is disabled
  • Ensure that download of file 1 is allowed and content is correct
  • Ensure that form can be submitted

Respondent 3

Attachments downloaded on admin response page should be the last submitted content

  • Ensure that the attachment for field 1 is file 3
  • Ensure that the attachment for field 2 is file 4

Ensure that scanner works

  • Using the MRF form prepared earlier
  • Download the eicar test file
  • Attach eicar file to field 1
  • Ensure that the form fails to submit and rejects with file has failed virus scan

fix(mrf): skip verifying OTP signatures on decryption for export #7192

@KenLSM

  • Create an MRF form with email and mobile otp for respondent 1 and another email and mobile otp for respondent 2. Fill the form for both respondents, then attempt to export the results as CSV. This should work.

feat(mrf): backend validation for field locking #7143

@KenLSM

Create a multirespondent form with a simple workflow (e.g. two respondents). Make sure there are a mix of shared and unshared fields (in this case "shared" means editable by both respondent 1 and respondent 2). In this example, I created a Q1 radio, Q2 dropdown, Q3 email, Q4 checkbox, Q5 yes/no, Q6 short answer. Respondent 1 is assigned Q1-4 and respondent 2 is assigned Q3-6, so that Q3 and Q4 are shared.

Initial submission

  • Send a valid submission via cURL. This should succeed.
curl 'http://localhost:3000/api/v3/forms/65680f30df564e005e446e2d/submissions/multirespondent?captchaResponse=null' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundarygrSB7FoxtaZ5Ycg7' \
  -H 'DNT: 1' \
  -H 'Origin: http://localhost:3000' \
  -H 'Referer: http://localhost:3000/65680f30df564e005e446e2d' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundarygrSB7FoxtaZ5Ycg7\r\nContent-Disposition: form-data; name="body"\r\n\r\n{"responses":{"6571f03219eb850112ae990e":{"fieldType":"radiobutton","answer":{"value":"Radio 1"}},"65d4238b1230effbfd6f74cb":{"fieldType":"dropdown","answer":"Dropdown 1"},"65f9257217e471530f22bcd9":{"fieldType":"email","answer":{"value":"[email protected]"}},"65d423891230effbfd6f74b7":{"fieldType":"checkbox","answer":{"value":["Checkbox 1"]}}},"responseMetadata":{"responseTimeMs":33230,"numVisibleFields":6},"version":3}\r\n------WebKitFormBoundarygrSB7FoxtaZ5Ycg7--\r\n'
{"message":"Form submission successful.","submissionId":"65f926ca17e471530f22bea5","timestamp":1710827210246}
  • Send a submission where a respondent 2-only field (e.g. Q5/6) is filled. This should be rejected by the server.
curl 'http://localhost:3000/api/v3/forms/65680f30df564e005e446e2d/submissions/multirespondent?captchaResponse=null' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundarygrSB7FoxtaZ5Ycg7' \
  -H 'DNT: 1' \
  -H 'Origin: http://localhost:3000' \
  -H 'Referer: http://localhost:3000/65680f30df564e005e446e2d' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundarygrSB7FoxtaZ5Ycg7\r\nContent-Disposition: form-data; name="body"\r\n\r\n{"responses":{"6571f03219eb850112ae990e":{"fieldType":"radiobutton","answer":{"value":"Radio 1"}},"65d4238b1230effbfd6f74cb":{"fieldType":"dropdown","answer":"Dropdown 1"},"65f9257217e471530f22bcd9":{"fieldType":"email","answer":{"value":"[email protected]"}},"65d423891230effbfd6f74b7":{"fieldType":"checkbox","answer":{"value":["Checkbox 1"]}},"65f9258417e471530f22bd46":{"fieldType":"yes_no","answer":"Yes"}},"responseMetadata":{"responseTimeMs":33230,"numVisibleFields":6},"version":3}\r\n------WebKitFormBoundarygrSB7FoxtaZ5Ycg7--\r\n'
{"message":"There is something wrong with your form submission. Please check your responses and try again. If the problem persists, please refresh the page."}

Respondent 2 submission
(if you're copying cURL from a browser network tab, don't forget to change the submissionId in the URL, the response itself, and the submission secret key in the data section)

  • Send a valid submission via cURL. This should succeed.
  • Send a submission where a shared field (e.g. Q3/4) is modified. This should succeed.
curl 'http://localhost:3000/api/v3/forms/65680f30df564e005e446e2d/submissions/65f926ca17e471530f22bea5?captchaResponse=null' \
  -X 'PUT' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryMAkuNxQsfBvsmprX' \
  -H 'DNT: 1' \
  -H 'Origin: http://localhost:3000' \
  -H 'Referer: http://localhost:3000/65680f30df564e005e446e2d/edit/65f9265b17e471530f22be96?key=o2QsH57uSqkqdkHelkoJt2UboIwb7alecrA7IOLlsJE%3D' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundaryMAkuNxQsfBvsmprX\r\nContent-Disposition: form-data; name="body"\r\n\r\n{"responses":{"6571f03219eb850112ae990e":{"fieldType":"radiobutton","answer":{"value":"Radio 1"}},"65d4238b1230effbfd6f74cb":{"fieldType":"dropdown","answer":"Dropdown 1"},"65f9257217e471530f22bcd9":{"fieldType":"email","answer":{"value":"[email protected]"}},"65d423891230effbfd6f74b7":{"fieldType":"checkbox","answer":{"value":["Checkbox 1","Checkbox 2"]}},"65f9258417e471530f22bd46":{"fieldType":"yes_no","answer":"No"},"65d423821230effbfd6f7464":{"fieldType":"textfield","answer":"abcde"}},"responseMetadata":{"responseTimeMs":7236,"numVisibleFields":6},"submissionSecretKey":"Z2T/aqbaHECMe+JX1Wpwlz0weEA9xm/m8PoSUCvR60U=","version":3}\r\n------WebKitFormBoundaryMAkuNxQsfBvsmprX--\r\n'
{"message":"Form submission successful.","submissionId":"65f926ca17e471530f22bea5","timestamp":1710827210246}
  • Send a submission where a respondent 1-only field is modified. This should be rejected by the server.
curl 'http://localhost:3000/api/v3/forms/65680f30df564e005e446e2d/submissions/65f926ca17e471530f22bea5?captchaResponse=null' \
  -X 'PUT' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryMAkuNxQsfBvsmprX' \
  -H 'DNT: 1' \
  -H 'Origin: http://localhost:3000' \
  -H 'Referer: http://localhost:3000/65680f30df564e005e446e2d/edit/65f9265b17e471530f22be96?key=o2QsH57uSqkqdkHelkoJt2UboIwb7alecrA7IOLlsJE%3D' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundaryMAkuNxQsfBvsmprX\r\nContent-Disposition: form-data; name="body"\r\n\r\n{"responses":{"6571f03219eb850112ae990e":{"fieldType":"radiobutton","answer":{"value":"Radio 2"}},"65d4238b1230effbfd6f74cb":{"fieldType":"dropdown","answer":"Dropdown 1"},"65f9257217e471530f22bcd9":{"fieldType":"email","answer":{"value":"[email protected]"}},"65d423891230effbfd6f74b7":{"fieldType":"checkbox","answer":{"value":["Checkbox 1"]}},"65f9258417e471530f22bd46":{"fieldType":"yes_no","answer":"No"},"65d423821230effbfd6f7464":{"fieldType":"textfield","answer":"abcde"}},"responseMetadata":{"responseTimeMs":7236,"numVisibleFields":6},"submissionSecretKey":"Z2T/aqbaHECMe+JX1Wpwlz0weEA9xm/m8PoSUCvR60U=","version":3}\r\n------WebKitFormBoundaryMAkuNxQsfBvsmprX--\r\n'
{"message":"There is something wrong with your form submission. Please check your responses and try again. If the problem persists, please refresh the page."}

Now, add logic to the form and make some fields optional.

Initial submission

  • With prevent submit logic, send a valid submission via cURL. This should succeed.
  • With prevent submit logic, send a submission via cURL such that submission should have been prevented. This should be rejected by the server.
  • With show fields logic, send a valid submission via cURL. This should succeed.
  • With show fields logic, send a submission via cURL such that a value is provided for a field that should have been hidden. This should be rejected by the server.

Respondent 2 submission
(take note that form fields and logic are saved with a submission lifetime, so you if you change the form logics you will need to make a new initial submission to generate a new edit link)

  • With prevent submit logic, send a valid submission via cURL. This should succeed.
  • With prevent submit logic, send a submission via cURL such that submission should have been prevented. This should be rejected by the server.
  • With show fields logic, send a valid submission via cURL. This should succeed.
  • With show fields logic, send a submission via cURL such that a value is provided for a field that should have been hidden. This should be rejected by the server.

fix: prefill myinfo dropdown field options when faking sample submission data #7225

@KenLSM

Regression Test
  • Create form with myinfo fields that has dropdown
  • Ensure that /api/v3/forms/:formId/sample-submissions API doesn't crash and returns data

dependabot bot and others added 30 commits March 19, 2024 21:55
…d @aws-sdk/client-ssm in /functions/form-payment-reconciliation (#6490)

chore(deps): bump fast-xml-parser, @aws-sdk/client-secrets-manager and @aws-sdk/client-ssm

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.2.5 and updates ancestor dependencies [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser), [@aws-sdk/client-secrets-manager](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-secrets-manager) and [@aws-sdk/client-ssm](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ssm). These dependencies need to be updated together.


Updates `fast-xml-parser` from 4.2.4 to 4.2.5
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5)

Updates `@aws-sdk/client-secrets-manager` from 3.347.1 to 3.360.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-secrets-manager/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.360.0/clients/client-secrets-manager)

Updates `@aws-sdk/client-ssm` from 3.347.1 to 3.360.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ssm/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.360.0/clients/client-ssm)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
- dependency-name: "@aws-sdk/client-secrets-manager"
  dependency-type: direct:production
- dependency-name: "@aws-sdk/client-ssm"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the npm_and_yarn group group with 2 updates: [@aws-sdk/client-cloudwatch-logs](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-cloudwatch-logs) and [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser).


Updates `@aws-sdk/client-cloudwatch-logs` from 3.348.0 to 3.536.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-cloudwatch-logs/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.536.0/clients/client-cloudwatch-logs)

Updates `fast-xml-parser` from 4.2.4 to 4.2.5
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-cloudwatch-logs"
  dependency-type: direct:production
  dependency-group: npm_and_yarn-security-group
- dependency-name: fast-xml-parser
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jest-mock-axios](https://github.com/knee-cola/jest-mock-axios) from 4.7.2 to 4.7.3.
- [Release notes](https://github.com/knee-cola/jest-mock-axios/releases)
- [Changelog](https://github.com/knee-cola/jest-mock-axios/blob/master/CHANGELOG.md)
- [Commits](knee-cola/jest-mock-axios@4.7.2...4.7.3)

---
updated-dependencies:
- dependency-name: jest-mock-axios
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/busboy](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/busboy) from 1.5.0 to 1.5.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/busboy)

---
updated-dependencies:
- dependency-name: "@types/busboy"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-essentials](https://github.com/krzkaczor/ts-essentials) from 9.3.1 to 9.4.1.
- [Release notes](https://github.com/krzkaczor/ts-essentials/releases)
- [Changelog](https://github.com/ts-essentials/ts-essentials/blob/master/CHANGELOG.md)
- [Commits](ts-essentials/ts-essentials@v9.3.1...v9.4.1)

---
updated-dependencies:
- dependency-name: ts-essentials
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/html-escaper](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/html-escaper) from 3.0.0 to 3.0.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/html-escaper)

---
updated-dependencies:
- dependency-name: "@types/html-escaper"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 4.0.8 to 4.1.0.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v4.0.8...v4.1.0)

---
updated-dependencies:
- dependency-name: "@opengovsg/mockpass"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 8.0.2 to 8.4.1.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](faker-js/faker@v8.0.2...v8.4.1)

---
updated-dependencies:
- dependency-name: "@faker-js/faker"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/cookie-parser](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/cookie-parser) from 1.4.3 to 1.4.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/cookie-parser)

---
updated-dependencies:
- dependency-name: "@types/cookie-parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 9.0.0 to 9.0.8.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid)

---
updated-dependencies:
- dependency-name: "@types/uuid"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#7169)

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.202 to 4.17.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7168)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.52 to 1.10.58.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.52...v1.10.58)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.9.1 to 10.9.2.
- [Release notes](https://github.com/TypeStrong/ts-node/releases)
- [Changelog](https://github.com/TypeStrong/ts-node/blob/main/development-docs/release-template.md)
- [Commits](TypeStrong/ts-node@v10.9.1...v10.9.2)

---
updated-dependencies:
- dependency-name: ts-node
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [zod](https://github.com/colinhacks/zod) from 3.22.3 to 3.22.4.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](colinhacks/zod@v3.22.3...v3.22.4)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [celebrate](https://github.com/arb/celebrate) from 15.0.1 to 15.0.3.
- [Release notes](https://github.com/arb/celebrate/releases)
- [Commits](arb/celebrate@v15.0.1...v15.0.3)

---
updated-dependencies:
- dependency-name: celebrate
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/convict](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/convict) from 6.1.1 to 6.1.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/convict)

---
updated-dependencies:
- dependency-name: "@types/convict"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.8.3 to 4.13.1.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.8.3...v4.13.1)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: upgrade bson from 5.4.0 to 5.5.1

Snyk has created this PR to upgrade bson from 5.4.0 to 5.5.1.

See this package in npm:
https://www.npmjs.com/package/bson

See this project in Snyk:
https://app.snyk.io/org/sebastianwzq/project/175e21a5-a82d-40de-a925-3f01820c6b66?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>
…7179)

Revert "chore(deps-dev): bump jest-mock-axios from 4.7.2 to 4.7.3 (#7154)"

This reverts commit e8e164e.
* feat: disabling response limit toggle for mrf

* fix: correcting const mrf acronym
build: merge release v6.113.0 back to develop
Bumps [rimraf](https://github.com/isaacs/rimraf) from 4.4.0 to 5.0.5.
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v4.4.0...v5.0.5)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.13.1 to 4.14.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.13.1...v4.14.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: remove babel-loader
* feat: disabling submit another response button for mrf 2nd respondent onwards

* fix: resolving suggestions from code review
* feat(mrf): backend validation for field locking

* refactor: move BE typeguards to its own file mimicking FE structure

* refactor: rename logic* to shared*

* refactor: use break instead of continue, clean up type assertions

* refactor: remove redundant existence check, clean up comments in validator

* refactor: use lodash isEqual instead of writing custom comparators, renaming of variables

---------

Co-authored-by: Ken <[email protected]>
…7195)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.58 to 1.10.59.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.58...v1.10.59)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 19 commits March 25, 2024 20:10
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: disabling mrf for singpass forms

* fix: refactoring code

* fix: correcting after code review
…7189)

Bumps [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) from 0.12.0 to 1.5.4.
- [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases)
- [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md)
- [Commits](playwright-community/eslint-plugin-playwright@v0.12.0...v1.5.4)

---
updated-dependencies:
- dependency-name: eslint-plugin-playwright
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [http-status-codes](https://github.com/prettymuchbryce/http-status-codes) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/prettymuchbryce/http-status-codes/releases)
- [Commits](prettymuchbryce/http-status-codes@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: http-status-codes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.49 to 1.10.59.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.49...v1.10.59)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.22.3 to 7.24.1.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.23.9 to 7.24.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.3/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [neverthrow](https://github.com/supermacro/neverthrow) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/supermacro/neverthrow/releases)
- [Commits](supermacro/neverthrow@v6.0.0...v6.1.0)

---
updated-dependencies:
- dependency-name: neverthrow
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1354.0 to 2.1585.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Commits](aws/aws-sdk-js@v2.1354.0...v2.1585.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mongodb-memory-server-core](https://github.com/nodkz/mongodb-memory-server/tree/HEAD/packages/mongodb-memory-server-core) from 9.1.6 to 9.1.7.
- [Release notes](https://github.com/nodkz/mongodb-memory-server/releases)
- [Changelog](https://github.com/nodkz/mongodb-memory-server/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodkz/mongodb-memory-server/commits/v9.1.7/packages/mongodb-memory-server-core)

---
updated-dependencies:
- dependency-name: mongodb-memory-server-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7201)

chore: prevent form activation if email confirmation is present
* fix: set submission limit to null for MRF

* chore: improve explanation comments on reasons for removing submission limit
* refactor: move override code closer to other overrides

* test: update test cases
fix: skip verifying OTP signatures on decryption for export
* chore: add info circle alt

* chore: update mrf copy on workflow pages

* chore: remove duplication typo
* feat: parse attachment content arraybuffer into file

* chore: enable attachment fields

* feat: add download button to attachment

* fix: clearing attachment not working

* fix: force dirty evaluation to true on file obj

* fix: shared typing on decrypted attachments

* chore: remove stray logs

* chore: hide remove attachment if field disabled

* fix: tint on download btn

* feat: save attachment on mrf update

* chore: remove misleading comments

* test: add storybook variant on attachment

* fix: show toast when mutateasync returns with error

* feat: compare attachment content by md5, and allow duplicate filenames

* chore: add sample download file on attachment storybook preview

* refactor: move shared/utils/response-v3 to BE as it contains BE-only code

* refactor: extract types from shared to be types

* refactor: extract normalization out from comparator to caller

* fix: update type imports
…ion data (#7225)

* fix: prefill myinfo dropdown field options when faking sample submission data

* fix: add appropriate sendStatus
@KenLSM KenLSM requested review from justynoh and kathleenkhy April 2, 2024 03:57
@kathleenkhy
Copy link
Contributor

kathleenkhy commented Apr 2, 2024

Found some issues:
image

  • when a file is empty (does not contain text)

Server timeout and/ or latency when files are larger: Gateway time-out Error code 504

@KenLSM KenLSM merged commit d84c3fa into release-al2 Apr 2, 2024
87 of 88 checks passed
@KenLSM KenLSM deleted the release_v6.114.0 branch April 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants