Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefill myinfo dropdown field options when faking sample submission data #7225

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Apr 2, 2024

Problem

Sample submission endpoint is causing server to crash for myinfo dropdown fields due to no field options being available to fake.

Solution

Pre-populate myinfo dropdowns with the right fieldOptions. Additionally, add more logging upon failures.

Breaking Changes

  • No - this PR is backwards compatible

@justynoh justynoh requested review from KenLSM and kathleenkhy April 2, 2024 02:55
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM merged commit 9741b70 into develop Apr 2, 2024
28 checks passed
@KenLSM KenLSM deleted the fix/sample-submission-throwing-errors branch April 2, 2024 03:44
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants