Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabling submit another response button (MRF) #7186

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Mar 22, 2024

Problem

The Submit Another Response button should be disabled for MRF forms' 2nd respondent onwards because the link used by the 2nd respondent onwards is meant to be a one-time link, and should not be re-accessed anymore. Hence, users who are 2nd respondents onwards should not be able to submit another response (and hence should not be accessing that link anymore after submitting).

This can be allowed for 1st respondents since the link is a public URL and is mean to be accessed by anyone with the link (use case: many applicants can access the link to submit an application, but backend, the approver should be approving the unique applications one by one)

To note: look into editing approvals in applications in the future?

Closes FRM-1694

Solution

The user should not be able to see the Submit another response button after submitting the form if they are Respondent 2 onwards so that it is clear that the process is meant for the respondents to only access the form once if they are not the first respondent.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:
image

AFTER:
image

Manual Tests

Check MRF forms

  • Create an MRF form
  • Create a workflow for multiple respondents under Add Workflow
  • Make a first submission as a first respondent
  • Check that the Submit another response button should be visible in the Thank you page
  • Make a submission as a second respondent
  • Check that the Submit another response button should be hidden/ not visible in the Thank you page

Check non-MRF forms

  • Create a normal non-MRF form
  • Make a submission
  • Check that the Submit another response button should be visible in the Thank you page

Copy link

linear bot commented Mar 22, 2024

@kathleenkhy kathleenkhy requested review from KenLSM and justynoh March 22, 2024 06:43
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kathleenkhy kathleenkhy merged commit 7f735f0 into develop Mar 25, 2024
22 checks passed
@kathleenkhy kathleenkhy deleted the feat/mrf-removing-feedback-submit-button branch March 25, 2024 05:52
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
40 tasks
KenLSM added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants