fix: correcting submission button bug for MRF #7232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous PR (#7186) to prevent the Submission button from showing for MRF Respondent #2 onwards resulted in a bug (and incident) where users would not be able to access the Admin view of non-payment forms' Thank You page.
The PR was subsequently reverted to undo the problem introduced. (#7231)
Solution
To add the use of Public Form Context to the parent of EndPageBlock (i.e. FormEndPage). The EndPageBlock component is also used in the Admin View (to show as a preview while the Admin use edits the form), resulting in an error because the component that is
public-form
is also rendered inadmin-form
.Breaking Changes
Tests
MRF Form test