Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor endpageblock to generic folder #7239

Closed

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Apr 3, 2024

Problem

Related to PR (#7232) to refactor by moving EndPageBlock.tsx file to a generic folder (out of the public-form folder) - this is to reduce confusion that the EndPageBlock.tsx is not entirely isolated to the public-form context and may cause downstream bugs and issues if the component is rendered incorrectly.

Closes FRM-1710

Solution

By moving EndPageBlock.tsx to a generic folder that is not within public-form or admin-form

Tests

  • Create a non-payment form
  • Proceed to the Thank You page tab

MRF Form test

  • Create an MRF form
  • Create 2 workflows
  • Submit the 1st workflow - the Submit another response button should be present
  • Submit the 2nd workflow - the Submit another response button should not be present

@kathleenkhy kathleenkhy requested a review from KenLSM April 3, 2024 06:43
Copy link

linear bot commented Apr 3, 2024

@kathleenkhy kathleenkhy requested a review from justynoh April 3, 2024 10:06
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's merge it after GA tomorrow.

@kathleenkhy kathleenkhy closed this Apr 5, 2024
@KenLSM KenLSM deleted the chore/refactor-endpageblock-to-generic-folder branch November 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants