Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.113.0 #7148

Merged
merged 14 commits into from
Mar 19, 2024
Merged

build: release v6.113.0 #7148

merged 14 commits into from
Mar 19, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 19, 2024

New

  • refactor(logic): consolidate logic functions into shared #7136
  • chore: Security upgrade nodemailer from 6.9.1 to 6.9.9 #7057
  • chore(dd): link source code to dd #7120
  • refactor(i18n): modularize and shard by feature #7134
  • chore: file download duration from S3 #7135
  • fix(virus-scanner): rework error logging in pino #7128
  • chore: add logs for virus scanning duration #7129
  • build: merge release v6.112.0 into develop #7127
  • build: release v6.112.0 #7126

Dependencies

  • fix(deps): bump follow-redirects from 1.15.4 to 1.15.6 #7139
  • build(deps): bump follow-redirects from 1.15.4 to 1.15.6 in /frontend #7138
  • build(deps): bump follow-redirects from 1.15.4 to 1.15.6 in /serverless/virus-scanner #7137
  • fix(deps): bump jose from 4.14.4 to 4.15.5 #7130

Dev-Dependencies

Tests

refactor(logic): consolidate logic functions into shared #7136

[@kathleenkhy ]

All tests are regression tests.

  • Show fields logic
    • Show fields based on "greater than or equal" to a number/decimal field.
    • Show fields based on "less than or equal" to a number/decimal field.
    • Show fields based on "equal" to a decimal field.
    • Show fields based on "either" for a radio field.
    • Show fields based on "either" for a radio field with "Others" as an option.
  • Prevent submit logic: repeat the same tests as above, but preventing submit instead of show fields.

chore(dd): link source code to dd #7120

@KenLSM
Regression

  • Make a Form Submission
  • Observe that it succeeds

KenLSM and others added 12 commits March 6, 2024 22:12
build: merge release v6.112.0 into develop
Bumps [jose](https://github.com/panva/jose) from 4.14.4 to 4.15.5.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md)
- [Commits](panva/jose@v4.14.4...v4.15.5)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Pino has in-built serialisers for logging Errors, but only on Errors
or Errors in nested `err` properties. Change logging accordingly.
* chore: add logs for virus scanning duration

* chore: adding duration logs for virus scan file download

* chore: rename downloadStartTime const

* chore: update downloadEndTime const name
* refactor(i18n): move locale files to specific directories

Prepare for sharding up of locale resources by moving each locale into
its own directory. Use this as the base to manage future growth and
expansion of locale resources to cover most text in FormSG.

No code change.

* refactor(i18n): add features dir, shard login locale

Hold feature-specific locale resources in a `features/` dir for each
locale, to minimise clutter even as we add more text to hold as
resources.

* refactor(i18n): reorg translations by feature, not locale
…ss/virus-scanner (#7137)

build(deps): bump follow-redirects in /serverless/virus-scanner

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#7138)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add env vars to docker

* chore: rename create-env to aws-ssm config

* add dd into ebextension

* add workflow cmd to insert values in eb script

* remove unused envvars from dockerfile

* fix: use + as sed delimiter

* fix: typo on comments
chore: upgrade nodemailer to 6.9.12

Co-authored-by: Ken <[email protected]>
* refactor(logic): consolidate logic functions into shared

* test: fix test import paths

* chore: add more details to comments, use shared function for isNonEmpty

* refactor: move internal radio field constant over to shared as SSOT

* chore: add comment to unreachable code path
@KenLSM KenLSM requested review from justynoh and kathleenkhy March 19, 2024 05:32
KenLSM added 2 commits March 19, 2024 14:13
* chore: remove unused html-loder

* chore: remove old webpack deps

* chore: remove angular-era deps

* clear off winston todo

* chore: update package-lock.json
@KenLSM KenLSM merged commit 9ba1e34 into release-al2 Mar 19, 2024
50 of 51 checks passed
@KenLSM KenLSM deleted the release_v6.113.0 branch March 19, 2024 07:09
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants