Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: file download duration from S3 #7135

Merged
merged 5 commits into from
Mar 14, 2024
Merged

chore: file download duration from S3 #7135

merged 5 commits into from
Mar 14, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Mar 13, 2024 •
edited
Loading

Problem

related to #7129 to track duration for file to be downloaded from S3

Closes [insert issue #]

Solution

Added logs to calculate time taken from start to end time of file download

Breaking Changes

  • No - this PR is backwards compatible

Manual Tests

  • Create a form with an attachment field
  • Complete a submission of the form
  • In datadog, search for "File download from S3 duration" - there should be a log result
  • Check that in Datadog, there should be logs under Submissions for a graph to track the duration of submissions (under Submissions >> Duration of file download from S3 (after virus scan))

@kathleenkhy kathleenkhy changed the title Chore/file download duration from s3 chore: file download duration from S3 Mar 13, 2024
@kathleenkhy kathleenkhy requested a review from KenLSM March 13, 2024 11:34
KenLSM
KenLSM approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 1 nit.

src/app/modules/submission/submission.service.ts Outdated Show resolved Hide resolved
@kathleenkhy kathleenkhy force-pushed the chore/file-download-duration-from-S3 branch from 7cdbdc4 to 1c11717 Compare March 14, 2024 05:24
@kathleenkhy kathleenkhy force-pushed the chore/file-download-duration-from-S3 branch from 1c11717 to 326c746 Compare March 14, 2024 05:34
@kathleenkhy kathleenkhy force-pushed the chore/file-download-duration-from-S3 branch from 326c746 to f881aa9 Compare March 14, 2024 05:39
@kathleenkhy kathleenkhy marked this pull request as ready for review March 14, 2024 05:50
@kathleenkhy kathleenkhy merged commit 51f538d into develop Mar 14, 2024
21 checks passed
@kathleenkhy kathleenkhy deleted the chore/file-download-duration-from-S3 branch March 14, 2024 06:07
@KenLSM KenLSM mentioned this pull request Mar 19, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathleenkhy @KenLSM