Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disabling MRF for Forms with SingPass #7200

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Mar 26, 2024

Problem

Currently Singpass is not compatible with MRF, and if someone shares a form that is SingPass enabled, it could cause the form to break when someone submits the MRF form. We should prevent users from duplicating forms that are singpass enabled to MRF to prevent errors that could occur downstream (at least until singpass features are built for MRF)

Closes FRM-1676

Solution

If a user duplicates an email/ storage-mode form that is SingPass enabled to an MRF, the option for MRF should be disabled to prevent the user from duplicating the form until the SingPass settings are disabled.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Without SingPass or creating a new form:
image

If SingPass is enabled:

image

Manual Tests

Creating a new form

  • Create a new form
  • All 3 options for Storage mode, email mode and MRF should be selectable

Duplicating a form without SingPass

  • Duplicate a form without SingPass
  • All 3 options for Storage mode, email mode and MRF should be selectable

Duplicating a form with SingPass

  • Duplicate a form with SingPass enabled
  • The option for MRF should be disabled, and not be able to be selected to proceed with the form duplication

Copy link

linear bot commented Mar 26, 2024

@kathleenkhy kathleenkhy requested a review from justynoh March 26, 2024 04:21
@kathleenkhy kathleenkhy marked this pull request as ready for review March 26, 2024 04:21
@kathleenkhy kathleenkhy requested review from KenLSM and removed request for KenLSM March 26, 2024 04:21
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justynoh justynoh merged commit 550069f into develop Mar 26, 2024
22 checks passed
@justynoh justynoh deleted the feat/disabling-singpass-for-mrf branch March 26, 2024 05:15
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants