chore(mrf): prevent form activation if email confirmation is present #7201
+33
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
deleted the
chore/prevent-form-activation-if-email-confirmations-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When users duplicate their forms from email/storage mode to MRF, they may have email confirmations present. We want to prevent them from opening the form with this setting enabled. This is purely a frontend block.
Closes FRM-1677
Solution
Perform a check on the activation toggle, pre-activation. Also, enable users to un-toggle the email confirmation in the email field themselves (i.e., only disable the toggle if email confirmations is already off).
Breaking Changes
Screenshots