[#3341] Add possibility to pass custom plot properties in request eg. canvasLegend #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest Everything is prepared and as a reasonable example, allow to turn of canvas legend in jqplot.
This was referenced Jul 22, 2010
Closed
Closed
Closed
This was referenced Aug 4, 2009
This was referenced Jul 22, 2010
ghost
mentioned this pull request
This was referenced Aug 3, 2012
Closed
This was referenced Jan 10, 2022
This was referenced May 2, 2023
Open
2 tasks
This was referenced Oct 2, 2023
Closed
4 tasks
sgiehl
added a commit
that referenced
this pull request
Feb 13, 2024
caddoo
pushed a commit
that referenced
this pull request
Feb 15, 2024
sgiehl
added a commit
that referenced
this pull request
Feb 15, 2024
sgiehl
added a commit
that referenced
this pull request
Feb 15, 2024
) * [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* * Apply coding style around FunctionCallSignature #1 (#21927) * Apply coding style around FunctionCallSignature #2 (#21928) * Apply coding style around FunctionCallSignature #3 (#21929) * Apply coding style around FunctionCallSignature #4 (#21930) * Apply coding style around FunctionCallSignature #5 (#21931) * Apply coding style around FunctionCallSignature #6 (#21932) * Apply coding style around FunctionCallSignature #7 (#21933) * Apply coding style around FunctionCallSignature #8 (#21934) * Apply coding style around FunctionCallSignature #9 (#21935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Tests pass: -
Fixes the following tickets: #3341
Todo: -
License of the code: MIT
Use case: The canvas legend of pie charts doesn't make sense, actually. Currently a canvas legend with the word "visits" is shown. This patch prepares piwik to customize plot parameters. Plot parameters that should be allowed to be customized need to be added to Piwik_ViewDataTable::init() to the protected$plotProperties variable. Plot options are then fully under control of PIWIK and if desires arise to customize other parameters as well, they can easily be added. Of course modifications to jqplot.js are unavoidable to $ .extend() the default settings.
Please review and tell if you can think of better implementations. This one seems pretty straight forward and transparent to me.