Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.1 compatibility] IPUtils.php(27): Deprecated - trim(): Passing null to parameter #1 ($string) of type string #20658

Closed
tsteur opened this issue May 3, 2023 · 0 comments · Fixed by #20661
Closed

[PHP 8.1 compatibility] IPUtils.php(27): Deprecated - trim(): Passing null to parameter #1 ($string) of type string #20658

tsteur opened this issue May 3, 2023 · 0 comments · Fixed by #20661
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.15.0

Comments

@tsteur
Copy link
Member

tsteur commented May 3, 2023

vendor/matomo/network/src/IPUtils.php(27): Deprecated - trim(): Passing null to parameter #1 ($string) of type string is deprecated - Matomo 4.14.3-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) [internal function]: Piwik\ErrorHandler::errorHandler(),#1/vendor/matomo/network/src/IPUtils.php(27),#2/core/Url.php(604),#3/plugins/LoginSaml/LoginSaml.php(213),[internal function]: Piwik\Plugins\LoginSaml\LoginSaml->loginNav(),#5/core/EventDispatcher.php(147),#6/core/Piwik.php(871),#7/core/Twig.php(273),#8/tmp/templates_c/39/39f806a356a577b904413ce7d3b3ecbc.php(352),#9/vendor/twig/twig/src/Template.php(171)

See above log. Shows up in the logs when using PHP 8.1. I don't have more information than that.

If this needs to be fixed in LoginSaml feel free to move the issue accordingly.
@tsteur tsteur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels May 3, 2023
@sgiehl sgiehl mentioned this issue May 3, 2023
Merged
11 tasks
@sgiehl sgiehl self-assigned this May 3, 2023
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels May 3, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone May 3, 2023
@sgiehl sgiehl modified the milestones: 5.0.0, 4.14.x May 5, 2023
@sgiehl sgiehl mentioned this issue May 5, 2023
Merged
11 tasks
@heurteph-ei heurteph-ei mentioned this issue Jul 3, 2023
Closed
2 tasks
@sgiehl sgiehl changed the title PHP 8.1 incompatibility - IPUtils.php(27): Deprecated - trim(): Passing null to parameter #1 ($string) of type string [PHP 8.1 compatibility] IPUtils.php(27): Deprecated - trim(): Passing null to parameter #1 ($string) of type string Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.15.0
Development

Successfully merging a pull request may close this issue.

Ensure IP is passed as string matomo-org/matomo
2 participants
@tsteur @sgiehl