Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: DevicesDetection: urlencode() Passing null to parameter #1 ($string) of type string is deprecated #20356

Closed
tsteur opened this issue Feb 13, 2023 · 0 comments · Fixed by #20360
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Feb 13, 2023

We tested running PHP 8.1 on Cloud, noticed this warning:

/var/www/html/plugins/DevicesDetection/API.php(129): Deprecated - urlencode(): Passing null to parameter #1 ($string) of type string is deprecated - Matomo 4.13.3 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) [internal function]: Piwik\ErrorHandler::errorHandler(),#1/plugins/DevicesDetection/API.php(129),[internal function]: Piwik\Plugins\DevicesDetection\API->Piwik\Plugins\DevicesDetection{closure}(),#3/core/DataTable.php(511),#4/plugins/DevicesDetection/API.php(133),[internal function]: Piwik\Plugins\DevicesDetection\API->getModel(),#6/core/API/Proxy.php(244),#7/core/Context.php(28),#8/core/API/Proxy.php(335),#9/core/Plugin/Visualization.php(341)

@tsteur tsteur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Feb 13, 2023
@sgiehl sgiehl self-assigned this Feb 14, 2023
@sgiehl sgiehl added this to the 4.13.4 milestone Feb 14, 2023
@sgiehl sgiehl mentioned this issue Feb 14, 2023
11 tasks
@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants