Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning - Trying to access array offset on value of type null in Events/VisitorDetails.php #20652

Open
tsteur opened this issue May 2, 2023 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@tsteur
Copy link
Member

tsteur commented May 2, 2023

plugins/Events/VisitorDetails.php(63): Warning - Trying to access array offset on value of type null - Matomo 4.14.3-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) #0/plugins/Events/VisitorDetails.php(63),#1/plugins/Live/Live.php(192),[internal function]: Piwik\Plugins\Live\Live->renderAction(),#3/core/EventDispatcher.php(147),#4/core/Piwik.php(871),#5/core/Twig.php(273),#6/tmp/templates_c/d4/d4ee03450ac17399246928fc7714bf9323df3833980575227b5b5ffd47e06387.php(82),#7/vendor/twig/twig/src/Template.php(394),#8/vendor/twig/twig/src/Template.php(367),#9/tmp/templates_c/eb/eb8697eb8db515a31b043d09e060d390bc128bc6262e5836e8a728f026df8b04.php(180)

Happened 3 times in the last 3 hours. This is all the information I have.

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. To Triage An issue awaiting triage by a Matomo core team member labels May 2, 2023
@michalkleiner michalkleiner self-assigned this May 3, 2023
@michalkleiner
Copy link
Contributor

Hi @tsteur,
thanks for logging the issue. I can see how/why the warning can be raised, I was not able to replicate it locally yet, but looking into it.

@michalkleiner
Copy link
Contributor

After a chat with the core team we think we should add safeguards to all the places where $action['type'] is expected to be set since it's possible for plugins to add custom actions without the type key set, and possibly also filter out any blank actions before trying to render them.

@michalkleiner michalkleiner removed the To Triage An issue awaiting triage by a Matomo core team member label May 4, 2023
@michalkleiner michalkleiner added this to the For Prioritization milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants