-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* #21926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2024
sgiehl
force-pushed
the
psr12_funccallsig
branch
from
February 15, 2024 09:27
ba1264f
to
7d16738
Compare
sgiehl
added
c: Tests & QA
For issues related to automated tests or making it easier to QA & test issues.
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Needs Review
PRs that need a code review
Technical debt
Issues the will help to reduce technical debt
labels
Feb 15, 2024
mneudert
approved these changes
Feb 15, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Tests & QA
For issues related to automated tests or making it easier to QA & test issues.
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Technical debt
Issues the will help to reduce technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR currently only contains the change to
phpcs.xml
. The required changes in the code are quite big, so I will split them into multiple PRs to be merged into this one. This should make reviewing a lot easier and faster.Note: Enabling those rule one by one doesn't make too much sense, as each rule on it own would make the code readability bit worse and in the end all files would be touched multiple times.
Review