Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* #21926

Merged
merged 10 commits into from
Feb 15, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 13, 2024

Description:

This PR currently only contains the change to phpcs.xml. The required changes in the code are quite big, so I will split them into multiple PRs to be merged into this one. This should make reviewing a lot easier and faster.

Note: Enabling those rule one by one doesn't make too much sense, as each rule on it own would make the code readability bit worse and in the end all files would be touched multiple times.

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Technical debt Issues the will help to reduce technical debt labels Feb 15, 2024
@sgiehl sgiehl requested a review from a team February 15, 2024 09:28
@sgiehl sgiehl merged commit e61eb91 into 5.0.x-dev Feb 15, 2024
24 of 25 checks passed
@sgiehl sgiehl deleted the psr12_funccallsig branch February 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants