-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Uninstall child of package #42607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fgsw Thanks for testing. I have updated the pr to resolve your issue |
I have tested this item ✅ successfully on b0a0162 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607. |
I have tested this item ✅ successfully on b0a0162 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607. |
rdeutz
approved these changes
Jan 6, 2024
Thanks! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 24, 2024
joomla/joomla-cms#42220 - (только для en-GB) joomla/joomla-cms#37320 + joomla/joomla-cms#42390 + joomla/joomla-cms#42393 + joomla/joomla-cms#42584 + joomla/joomla-cms#42607 + joomla/joomla-cms#42402 + joomla/joomla-cms#42334 + joomla/joomla-cms#42610 + joomla/joomla-cms#42663 + joomla/joomla-cms#42747 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42596 .
Summary of Changes
If you try to uninstall an extension that is a package you can't and get a message doesnt indicate what package.
This pr adds a new variable to the string so that there is now a direct link to the package
Because of our semver rules on language strings this is made against j5.1
Testing Instructions
Install any package extension eg a language
Go to System => Manage => Extensions
Filter for languages and then try to uninstall one
Actual result BEFORE applying this Pull Request
The < named > extension is part of a [ package ] which does not allow individual extensions to be uninstalled.
Expected result AFTER applying this Pull Request
The < named > extension is part of a [ package ]( index.php?option=com_installer&view=manage&filter[search]=id:XX) which does not allow individual extensions to be uninstalled.
The link will directly open the package so it can be selected and uninstalled.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed