Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Workflows missing strings #42390

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

brianteeman
Copy link
Contributor

AFAICT these strings have been missing since the beginning. They are used in

administrator/components\com_workflow\src\Controller\StagesController.php administrator/components\com_workflow\src\Controller\TransitionController.php administrator/components\com_workflow\src\Controller\WorkflowsController.php

This has been made against 5.1 as they are new strings

Testing Instructions

code review should be fine

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

AFAICT these strings have been missing since the beginning. They are used in

administrator/components\com_workflow\src\Controller\StagesController.php
administrator/components\com_workflow\src\Controller\TransitionController.php
administrator/components\com_workflow\src\Controller\WorkflowsController.php

This has been made against 5.1 as they are new strings
@HLeithner HLeithner added the bug label Nov 23, 2023
@Quy
Copy link
Contributor

Quy commented Nov 23, 2023

I have tested this item ✅ successfully on 0d632fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0d632fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390.

@Quy Quy removed the bug label Nov 23, 2023
@Quy
Copy link
Contributor

Quy commented Nov 23, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 23, 2023
@Quy Quy added the bug label Nov 23, 2023
@Razzo1987 Razzo1987 merged commit fa672f1 into joomla:5.1-dev Nov 30, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 30, 2023
@Razzo1987
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants