Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Subform rows sorting with buttons, addittionaly to drag and drop #42334

Merged
merged 15 commits into from
Jan 12, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 11, 2023

Summary of Changes

Add posibility to sort subform rows with buttons "up" and "down".
Useful for large forms.

Screenshot 2023-11-11_20-58-38

Fix for #39092

Testing Instructions

Run npm install
Create a subform somewhere:

<field type="subform" name="subform" label="subform" multiple="true">
  <form>
    <field type="text" name="text" label="Text"/>
  </form>
</field>

And use new up/down button for rows sorting

Actual result BEFORE applying this Pull Request

nothing

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Nov 11, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Nov 11, 2023
@Fedik Fedik added the Feature label Nov 11, 2023
@Quy
Copy link
Contributor

Quy commented Nov 12, 2023

I have tested this item ✅ successfully on 89a503e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

@AndySDH
Copy link
Contributor

AndySDH commented Nov 12, 2023

This approach is a bit reductive and I don't feel like it fully addresses #39092. Dragging and dropping is still very bad, and I don't think adding an up and down arrow is enough to call the problem solved...

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 89a503e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

@Quy Quy removed Feature Language Change This is for Translators labels Nov 13, 2023
@Quy
Copy link
Contributor

Quy commented Nov 13, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 13, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Dec 16, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Dec 16, 2023
@LadySolveig LadySolveig merged commit 31659bb into joomla:5.1-dev Jan 12, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

A heartfelt thanks @Fedik and thanks to the testers @viocassel @Quy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants