-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Add Global Setting for Form Layout option to custom fields #37320
Conversation
Allows for shared language string shared across multiple fields plugins (to avoid duplicating them for multiple fields)
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
You will have to wait for the issue tracker to get back online, I am afraid. This is the only way you can cast your test. In the meantime, Richard set the PR as RTC, which acknowledges your test. |
Thank you :) |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37320. |
Many thanks for this contribution @AndySDH and the very nice teamwork! |
I have tested this item ✅ successfully on 9137eee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37320. |
joomla/joomla-cms#42220 - (только для en-GB) joomla/joomla-cms#37320 + joomla/joomla-cms#42390 + joomla/joomla-cms#42393 + joomla/joomla-cms#42584 + joomla/joomla-cms#42607 + joomla/joomla-cms#42402 + joomla/joomla-cms#42334 + joomla/joomla-cms#42610 + joomla/joomla-cms#42663 + joomla/joomla-cms#42747 +
Pull Request for Issue #37162. Follow-up to PR #36551 and issue #36548.
Purpose of the PR
As discussed in #37162, this allows users to set a global preference for the HTML Select for custom fields of types: list, SQL, radio, integer.
I would have just removed the option, as the "raw" select is just ugly, but @laoneo noted that we need to keep it for Backwards Compatibility.
Summary of Changes
Testing Instructions
First create the custom field:
Then:
Actual result BEFORE applying this Pull Request
There was no global setting to inherit from the plugin for 'Form Layout'
Expected result AFTER applying this Pull Request
There is now a global setting for 'Form Layout' that controls the default value when not specified in an individual field.
Changing the global setting will change the form layout of the field.