Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Alias string consistency #42220

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 26, 2023

five years later as requested by @rdeutz ... redo of #19857

Pull Request for Issue #19856 reported by @MartijnMaandag

Summary of Changes

On the Tab 'Publishing' we do have the label 'Created by Alias' in Contacts, Banners and Articles (although in Contacts it is 'Created By Alias' with capital 'B').

This PR makes them all "Created by Alias"

In Tags, Newsfeeds and frontend content editing this is uses a generic string called 'Author's Alias'.

This PR makes the generic string "Created by Alias" and updates the generic description

@Quy
Copy link
Contributor

Quy commented Oct 26, 2023

I have tested this item ✅ successfully on da0bd8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42220.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Oct 26, 2023

I have tested this item ✅ successfully on da0bd8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42220.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-5.1-dev labels Oct 26, 2023
@alikon
Copy link
Contributor

alikon commented Oct 26, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42220.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev RTC This Pull Request is Ready To Commit labels Oct 26, 2023
@rdeutz rdeutz merged commit ba10527 into joomla:5.1-dev Oct 26, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 26, 2023
@brianteeman brianteeman deleted the alias-five_years_later branch October 26, 2023 18:46
@Quy Quy added this to the Joomla! 5.1.0 milestone Oct 26, 2023
@adj9
Copy link

adj9 commented Feb 24, 2024

By installing the PR from scratch the administrative homa does not have the cottect style, the titles of all boxes are to be reduced.
While the other pages , such as articles and system, work
JD

@brianteeman
Copy link
Contributor Author

@adj9 you posted that report on the wrong issue

@Razzo1987
Copy link
Contributor

thanks @brianteeman ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants