Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] add language deprecation for #37320 #42584

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Dec 31, 2023

Summary of Changes

Add back the removed strings of #37320 and deprecate them @AndySDH @Razzo1987
Update language constant of custom field subform to not use deprecate string

Testing Instructions

add new custom field of type subform
open tab options

Actual result BEFORE applying this Pull Request

untranslated string
image
image

Expected result AFTER applying this Pull Request

string translated
image

Link to documentations

Please select:

@Quy
Copy link
Contributor

Quy commented Jan 1, 2024

I have tested this item ✅ successfully on 055caef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42584.

1 similar comment
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 055caef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42584.

@Quy
Copy link
Contributor

Quy commented Jan 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42584.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 1, 2024
@Razzo1987 Razzo1987 merged commit 6847b5a into joomla:5.1-dev Jan 5, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 5, 2024
@Razzo1987
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants