Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] user profile dob field #38065

Merged
merged 6 commits into from
Jun 16, 2022
Merged

[4.2] user profile dob field #38065

merged 6 commits into from
Jun 16, 2022

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jun 15, 2022

To test enable the user profile plugin and update the date of birth field for your user account

Pull Request for Issue #28883

This is a simpler alternative to #38057 that does not use a customised field

image
.

Summary of Changes

To test enable the user profile plugin and update the date of birth field for your user account
@AndySDH
Copy link
Contributor

AndySDH commented Jun 15, 2022

Nice! Should the whole profile/fields folder be deleted since there's no file in there anymore?

@brianteeman
Copy link
Contributor Author

it is but you can tell from the way github displays the diff

image

@AndySDH
Copy link
Contributor

AndySDH commented Jun 15, 2022

Did you mark the parent /layouts/plugins/user/ for deletion in the script (line 7844)? That one should not be deleted as it also contains 'terms' and 'token' subfolders

@brianteeman
Copy link
Contributor Author

no

@richard67
Copy link
Member

Pull Request for #2883

@brianteeman It seems there is a digit missing in the referred issue number.

@brianteeman
Copy link
Contributor Author

Pull Request for #2883

@brianteeman It seems there is a digit missing in the referred issue number.

it was missing an 8 - i have updated the reference

@Kostelano
Copy link
Contributor

Why a description that duplicates a hint?

@brianteeman
Copy link
Contributor Author

Why a description that duplicates a hint?

If there was only a hint then you wouldnt know the date format when the user profile is displayed as you obviously only see the hint when in edit mode.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 40a1013


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38065.

@AndySDH
Copy link
Contributor

AndySDH commented Jun 16, 2022

I have tested this item ✅ successfully on 40a1013

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38065.

@alikon
Copy link
Contributor

alikon commented Jun 16, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38065.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67 richard67 merged commit 5a6a55f into joomla:4.2-dev Jun 16, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67
Copy link
Member

Thanks

@richard67 richard67 added this to the Joomla 4.2.0 milestone Jun 16, 2022
@brianteeman brianteeman deleted the dob branch June 16, 2022 15:51
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
roland-d pushed a commit that referenced this pull request Jun 20, 2022
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants