-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Joomla! Update error state #38002
Conversation
@Kostelano I kept the same margins and padding as the progress bar. It looks funny to me too. Maybe I could change the my-5 to my-2 to pull it a bit further up. You can play with the classes when seeing this page using the browser's dev tools to see what I mean. Ideas welcome. |
As far as indentation goes, I'd rather remove the As for the help page, I've reopened issue #35668, which I signaled earlier. But for version 4.0, it was left without attention. At one point I was unable to reproduce the problem and closed it, but now I see that it is still not resolved. |
I have tested this item ✅ successfully on 127274f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38002. |
@Kostelano Thank you! |
I have tested this item ✅ successfully on 127274f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38002. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38002. |
Thanks everybody. @nikosdion Mike Brandner is looking at the 4.2 links for the wiki |
Thank you very much, Roland! Much appreciated, mate! |
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
Pull Request for Issue #37870 .
Ping @brianteeman @richard67 @jeckodevelopment
Summary of Changes
extract.php
to set a long PHP timeout (3600s) and a very large memory limit (1GiB) to minimise easily negotiable server limits from interfering with the update.extract.php
as a Denial of Service attack.WE DESPERATELY NEED THE HELP PAGE IN THE JOOMLA DOCUMENTATION SITE!. People, please remember that I have already written the content for you and it's in PR #35388
PLEASE tell me how to put this documentation in the wiki so that the More Information button in the error state of Joomla! Update actually gives the user useful, reliable information instead of leading to a Wiki error page!!!
Testing Instructions
Go to Joomla Update and start an update with an uploaded file. Use the sabotaged ZIP file below: sabotage.zip
Actual result BEFORE applying this Pull Request
You get an error dialog. Closing the dialog... you have no idea what to do.
Expected result AFTER applying this Pull Request
You get an error pane. You can retry the extraction or give up and go back to Joomla Update. Please test these buttons work.
If you want to test the retry/restart buttons, open your site's tmp directory. You will see a file named something like
juiXFAzI
and its size will be 6815744 bytes. That's our sabotage.zip file. Replace it with the following, fixed file:mirage.zip
(Bonus points if you guessed the song these filenames refer to)
Upon replacing the file and hitting retry or restart the update will run to completion. You will get a folder named _deleteme under your site's root with the following files. I also give you their MD5 sums:
All files are exactly 2097152 bytes long.
Documentation Changes Required
There are no changes to the documentation I already gave you and has not been copied over to the documentation wiki.