[4.1] User defined Hide Table Columns #36591

brianteeman · 2022-01-06T20:49:47Z

Summary of Changes

Decide for yourself which columns to display for any table. The button shows an updating count of how many columns are shown.

The choice of which column to display is stored in local storage so it is persistent for you in your browser for that site.

This should be added to every table and it can also be added by extension developers to their own table by just adding one line to the existing web assets.

// add the script
/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->document->getWebAssetManager();
$wa->useScript('table.columns');

Testing Instructions

As there is new js you will need to run npm ci

This is a fork and continuation of work by @PhilETaylor @dgrammatiko @Fedik

build/media_source/system/js/table-columns.es6.js

brianteeman · 2022-01-06T20:59:15Z

Yes thats out of scope

No I'm not moving it to the bottom. It makes no sense to hide it on the bottom of the second or third page scroll

Co-authored-by: Dimitris Grammatikogiannis <[email protected]>

brianteeman · 2022-01-06T21:00:58Z

your face must be really bruised the number of times that you smash your palm into it

roland-d · 2022-02-01T20:25:36Z

@brianteeman As Joomla 4.1 is in feature freeze Benjamin asked me to merge it for 4.2. I agree this is a great feature, so have it merged for 4.2.

Thanks everybody for working on this.

brianteeman · 2022-02-01T20:50:27Z

thanks for merging - shame people will have to wait :(

Kostelano · 2022-02-11T07:37:55Z

Please add a language tag to the PR

joeforjoomla · 2022-02-15T13:24:17Z

This script is too much generic if used for third-party extensions. It searches for all tables in a page throwing a JS error if there is no head section or applying the hide columns control to all found tables even if undesired.
It's a pity it can't be used only for the main or specific table in backend. It would be great an addition to exclude or include only tables that really need it.

Fedik · 2022-02-15T15:22:32Z

Well, that was expected. But people wanted like that.
You better open an issue with some "test case" description. If you like.

brianteeman · 2022-02-15T15:32:39Z

a table without a head section is invalid so not going to apologise if it doesnt work

brianteeman · 2022-02-16T07:11:29Z

It would be great an addition to exclude or include only tables that really need it.

I dont understand - you have to add it to your component to use it. its not automatic

joeforjoomla · 2022-02-16T10:51:14Z

It would be great an addition to exclude or include only tables that really need it.

I dont understand - you have to add it to your component to use it. its not automatic

@brianteeman of course i know.

The problem now, is that this code should skip unnamed tables, but actually it doesn't do this because if a table has no name it fallbacks to the header title:

const tableName = $table.dataset.name ? $table.dataset.name : document.querySelector('.page-title').textContent.trim().replace(/[^a-z0-9]/gi, '-').toLowerCase(); // Skip unnamed table

    if (!tableName) {
      return;
    }

As a consequence if there are let's say 3 tables in the backend interface of a component but not all 3 tables used for columns to be hidden, then this feature will apply to all of them.
Furthermore, if a table has an empty <head></head> without any <tr>, than you have a the javascript error because of this line of code looking at the 'children' attribute of null:

this.$headers = [].slice.call($table.querySelector('thead tr').children);
Then it should be the case to fix the 'children' code to avoid a JS error, or to introduce an option for a configurable JS selector to include or exclude only certain tables.

I hope to have well explained.

brianteeman · 2022-02-16T10:53:16Z

Two choices

Don't implement the script in your component
Submit a pull request with the required changes

impressionestudio · 2022-08-17T10:53:35Z

Very useful option but...

Why the new dropdown list button for the columns is placed in a new line and not in the same row and after the dropdown list button for the list limit?

As, for example, the list limit button affects the table, also does this new button for the columns of the table. So they should placed together.

There is space for them to fit in one row and if the left menu is closed then there is more space. I think we need to stop pushing the table too much down.

Also the other filters have a specific ID or class e.g. "list_limit", "list_fullordering". Why the new button for the columns doesn't have?

HSorgYves · 2022-09-07T19:45:33Z

d-xxl-table-cell, d-sm-table-cell and d-xs-table-cell aren't removed by the JavaScript. Can you please adjust the JS?

brianteeman and others added 20 commits December 22, 2021 20:19

from phil

7a60ab5

disable checkbox not remove it

2f79440

prepare column count

3132419

lang

aa0ac93

attribs

5958db4

comments

93a5624

fix column count

0d93c22

updatecheck

7fe4182

using object instead of multiple setattribute

357404f

minus

3afbf44

breakpoint

0640f1d

cs

82dc916

use web assets

079424b

lint

1236207

Fix table-columns.js (#153)

3eedadf

lint

c09474c

more lint

b20804b

disable

8db8e9a

classes

c5db502

tables

f436feb

joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Jan 6, 2022

Merge branch '4.1-dev' into table_columns

bbac16e

dgrammatiko suggested changes Jan 6, 2022

View reviewed changes

build/media_source/system/js/table-columns.es6.js Outdated Show resolved Hide resolved

Update build/media_source/system/js/table-columns.es6.js

5e557b1

Co-authored-by: Dimitris Grammatikogiannis <[email protected]>

This comment was marked as abuse.

Sign in to view

brianteeman added 3 commits January 31, 2022 23:23

Update default.php

e6b54ae

Update default.php

9fca3b1

conflicts

a0043c4

roland-d changed the base branch from 4.1-dev to 4.2-dev February 1, 2022 19:47

Merge branch '4.2-dev' into table_columns

ec81ab9

joomla-cms-bot added the PR-4.2-dev label Feb 1, 2022

Quy removed the PR-4.1-dev label Feb 1, 2022

roland-d merged commit d0d4ed7 into joomla:4.2-dev Feb 1, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 1, 2022

roland-d added this to the Joomla 4.2.0 milestone Feb 1, 2022

brianteeman deleted the table_columns branch February 1, 2022 20:50

Fedik added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Feb 11, 2022

zero-24 mentioned this pull request Feb 15, 2022

[4.2] User defined Hide Table Columns joomlagerman/joomla#2271

Closed

wojsmol mentioned this pull request Feb 15, 2022

[4.2] User defined Hide Table Columns JoomlaPolska/jezyk-J4#132

Closed

heelc29 mentioned this pull request Mar 25, 2022

[4.2] Remove duplicate WebAssetManager #37379

Merged

MrMusic mentioned this pull request Oct 10, 2022

Add Hide Table Columns for categories and images JoomGalleryfriends/JG4-dev#45

Merged

ChristineWk mentioned this pull request Nov 17, 2024

[5.3.0] User defined Hide Table Columns - to be saved permanently - Feature Request #44468

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.1] User defined Hide Table Columns #36591

[4.1] User defined Hide Table Columns #36591

brianteeman commented Jan 6, 2022

brianteeman commented Jan 6, 2022

brianteeman commented Jan 6, 2022

This comment was marked as abuse.

This comment was marked as abuse.

roland-d commented Feb 1, 2022

brianteeman commented Feb 1, 2022

Kostelano commented Feb 11, 2022

joeforjoomla commented Feb 15, 2022 •

edited

Loading

Fedik commented Feb 15, 2022

brianteeman commented Feb 15, 2022

brianteeman commented Feb 16, 2022

joeforjoomla commented Feb 16, 2022 •

edited

Loading

brianteeman commented Feb 16, 2022

impressionestudio commented Aug 17, 2022

HSorgYves commented Sep 7, 2022 •

edited

Loading

[4.1] User defined Hide Table Columns #36591

[4.1] User defined Hide Table Columns #36591

Conversation

brianteeman commented Jan 6, 2022

Summary of Changes

Testing Instructions

brianteeman commented Jan 6, 2022

brianteeman commented Jan 6, 2022

This comment was marked as abuse.

This comment was marked as abuse.

roland-d commented Feb 1, 2022

brianteeman commented Feb 1, 2022

Kostelano commented Feb 11, 2022

joeforjoomla commented Feb 15, 2022 • edited Loading

Fedik commented Feb 15, 2022

brianteeman commented Feb 15, 2022

brianteeman commented Feb 16, 2022

joeforjoomla commented Feb 16, 2022 • edited Loading

brianteeman commented Feb 16, 2022

impressionestudio commented Aug 17, 2022

HSorgYves commented Sep 7, 2022 • edited Loading

joeforjoomla commented Feb 15, 2022 •

edited

Loading

joeforjoomla commented Feb 16, 2022 •

edited

Loading

HSorgYves commented Sep 7, 2022 •

edited

Loading