Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package filter in the Extensions: Manage page #37838

Merged
merged 10 commits into from
Jun 6, 2022
Merged

Package filter in the Extensions: Manage page #37838

merged 10 commits into from
Jun 6, 2022

Conversation

nikosdion
Copy link
Contributor

Summary of Changes

Adds a Package filter in the Extensions: Manage page.

Testing Instructions

Go to System, Manage, Extensions

Actual result BEFORE applying this Pull Request

Filtering the list of extensions by the extension package ID they belong to is not possible.

Expected result AFTER applying this Pull Request

You have a Package dropdown filter. Choosing a package shows you that package extension and all extensions Joomla knows belong to that package (based on the recorded package_id in the database).

Documentation Changes Required

You need to document the Package filter:

  • Package. Displays only the selected "package" type extension and all extensions which belong to it. Note: You should only uninstall the "package" type extension to prevent extension and core Joomla update problems.

Translation Changes Required

Two translation keys were added

Reasoning for this PR

It is very important that users only ever try to uninstall the "package" extension, not the individual extensions a package contains. Failing to do so will cause all sorts of problems:

  • Trying to uninstall the package extension displays warnings about missing extensions which cannot be uninstalled.
  • Some packages fail to uninstall because their installation scripts expect one or more of the included extensions to be present when the package uninstallation takes place.
  • Removing all included extensions but not the package itself will find updates. Installing the updates reinstalls the missing extensions which can be confusing and disorienting for the user.
  • Removing some of the extensions included in a package, for example some plugins, may cause the other extensions to fail in unpredictable ways.

Right now the only indication that an extension is part of a package is the meaningless Package ID column. Ask 100 users what that is for and 99 will have no idea.

Even worse, those of us who do know what it is cannot filter by a package ID, making it extremely hard to locate all extensions which belong to a package. We would have to search for the package name, note down the package ID, clear the filter, sort the list by package ID, start going through the pagination until we find the package ID in question in the rightmost column and carefully examine which extensions it contains. This is a very Soviet user experience, the only thing missing are the people in long coats asking us to please follow them to the back room for questioning.

With a filter like that it's easy to pinpoint the extensions included in a package, complete with the package itself. This makes management far easier on real world sites (default installations don't really have any packages, rendering this a moot point — but almost nobody runs Joomla like that in the real world).

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels May 20, 2022
@SumCompanyInc
Copy link

I have tested this item ✅ successfully on 7473cca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

1 similar comment
@alikon
Copy link
Contributor

alikon commented May 21, 2022

I have tested this item ✅ successfully on 7473cca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

@alikon
Copy link
Contributor

alikon commented May 21, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 21, 2022
@bembelimen
Copy link
Contributor

Nice addition, but I will move to 4.2 and ping @roland-d to merge is asap.

@bembelimen bembelimen changed the base branch from 4.1-dev to 4.2-dev June 5, 2022 22:47
@nikosdion
Copy link
Contributor Author

@bembelimen No problem and thank you!

@roland-d roland-d merged commit bde3e00 into joomla:4.2-dev Jun 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 6, 2022
@roland-d
Copy link
Contributor

roland-d commented Jun 6, 2022

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants