-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package filter in the Extensions: Manage page #37838
Merged
roland-d
merged 10 commits into
joomla:4.2-dev
from
nikosdion:feature/extman-package-select
Jun 6, 2022
Merged
Package filter in the Extensions: Manage page #37838
roland-d
merged 10 commits into
joomla:4.2-dev
from
nikosdion:feature/extman-package-select
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kostelano
reviewed
May 20, 2022
Co-authored-by: Konstantin Kolos <[email protected]>
heelc29
suggested changes
May 21, 2022
administrator/components/com_installer/src/Field/PackageField.php
Outdated
Show resolved
Hide resolved
administrator/components/com_installer/src/Helper/InstallerHelper.php
Outdated
Show resolved
Hide resolved
administrator/components/com_installer/src/Model/ManageModel.php
Outdated
Show resolved
Hide resolved
administrator/components/com_installer/src/Field/PackageField.php
Outdated
Show resolved
Hide resolved
administrator/components/com_installer/src/Helper/InstallerHelper.php
Outdated
Show resolved
Hide resolved
Co-authored-by: heelc29 <[email protected]>
…per.php Co-authored-by: heelc29 <[email protected]>
Co-authored-by: heelc29 <[email protected]>
…per.php Co-authored-by: heelc29 <[email protected]>
Co-authored-by: heelc29 <[email protected]>
heelc29
reviewed
May 21, 2022
Co-authored-by: heelc29 <[email protected]>
I have tested this item ✅ successfully on 7473cca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838. |
1 similar comment
I have tested this item ✅ successfully on 7473cca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838. |
Nice addition, but I will move to 4.2 and ping @roland-d to merge is asap. |
@bembelimen No problem and thank you! |
Thanks everybody |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Jun 7, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 6, 2022
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a Package filter in the Extensions: Manage page.
Testing Instructions
Go to System, Manage, Extensions
Actual result BEFORE applying this Pull Request
Filtering the list of extensions by the extension package ID they belong to is not possible.
Expected result AFTER applying this Pull Request
You have a Package dropdown filter. Choosing a package shows you that package extension and all extensions Joomla knows belong to that package (based on the recorded package_id in the database).
Documentation Changes Required
You need to document the Package filter:
Translation Changes Required
Two translation keys were added
Reasoning for this PR
It is very important that users only ever try to uninstall the "package" extension, not the individual extensions a package contains. Failing to do so will cause all sorts of problems:
Right now the only indication that an extension is part of a package is the meaningless Package ID column. Ask 100 users what that is for and 99 will have no idea.
Even worse, those of us who do know what it is cannot filter by a package ID, making it extremely hard to locate all extensions which belong to a package. We would have to search for the package name, note down the package ID, clear the filter, sort the list by package ID, start going through the pagination until we find the package ID in question in the rightmost column and carefully examine which extensions it contains. This is a very Soviet user experience, the only thing missing are the people in long coats asking us to please follow them to the back room for questioning.
With a filter like that it's easy to pinpoint the extensions included in a package, complete with the package itself. This makes management far easier on real world sites (default installations don't really have any packages, rendering this a moot point — but almost nobody runs Joomla like that in the real world).