-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Workflow Notification no recipient #37747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
changed the title
[4.1] Workflow Notification no recipient
[4.2] Workflow Notification no recipient
Jun 22, 2022
rebased to 4,2 now that there will be no further 4.1 releases |
I have tested this item ✅ successfully on 359dfb9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747. |
This pull requests has been automatically converted to the PSR-12 coding standard. |
brancg updated to restart drone |
I have tested this item ✅ successfully on da184b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747. |
Thank you. |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 6, 2022
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 12, 2022
* [4.1] Workflow Notification no recipient * cs * Phase 1 convert BRANCH to PSR-12 * Phase 2 convert BRANCH to PSR-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #37744
Test Setup Instructions
Test 1
only proceed to test 2 & 3 when you are sure that you are gettig the email
Test 2
Before this PR
No notifications sent and no message displayed
After this PR
No notifications sent and a message is displayed - I am very open to suggestions for a better message
Test 3
In the transition remove the usergroup
Before this PR
No notifications sent and no message displayed
After this PR
No notifications sent and a message is displayed - I am very open to suggestions for a better message