-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hide Table Columns for categories and images #45
Add Hide Table Columns for categories and images #45
Conversation
ENV: https://prnt.sc/uVfTvuEhFb4v
RESULT
EXPECTED RESULT
Issue do not appear if there is enough items on the list, and list is longer than dropdown. |
ENV: https://prnt.sc/uVfTvuEhFb4v
Issue apply to both Image and Category manager. Maybe we should have this column named in the list header (No sorting is needed here)? |
While testing on Windows, I encountered issue right after installation.
Only those two places are affected. All other e.g Configuration Manager are ok. |
Done.
I cannot reproduce this. Did you perform a new installation after deinstallation? |
This effect is due to the fact that other classes are currently used in JoomGallery than in the corresponding Joomla views. I don't know if this is intentional? |
@MrMusic BINGO! That was the source of issue. Upgraded to latest version and issue was gone. |
I confirm that latest commit was tested on both Linux and Windows. Everything works and looks good. |
<div class="col-md-12"> | ||
<div id="j-main-container" class="j-main-container"> | ||
<?php echo LayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?> | ||
<table class="table" id="categoryList"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the reason for removing the "table-striped" class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the div with class "table-responsive" I would leave there anyway. In that way there is a horizontal scroll bar if to many rows are visible for the current screen width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the classes so that it is the same as in Joomla.
The missing scrollbars are actually a disadvantage here.
Now i have reversed it.
@MrMusic Since you are changing only the template files of images and category manager, I can not see any negative side effects except for the fact that it is displayed differently as the first implementation was suggested. |
This reverts commit 490ab0b.
Sorry, the fix also prevented the horizontal scrollbars from appearing. so i had to reverse it. |
Since joomla 4.2 there is a nice feature to hide any column in the table views: joomla/joomla-cms#36591
@szepty-ziemi had already suggested the implementation at the last online meeting.
Surprisingly, the implementation in the JoomGallery was very simple.
Used for categories and images view because in tags and configuration view there are only a few columns.