Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Update deleted files and folders for 4.2.0-beta2 #38039

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jun 12, 2022

Pull Request for Issue # .

Summary of Changes

Update the lists of files and folders to be deleted on update by script.php to the latest changes in the 4.2-dev branch in preparation of the upcoming 4.2.0 Beta 2.

Following files and folder from following PR's are included (note that this includes the old location of moved files):

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.2.0-beta1 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-beta1 to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

Files and folders mentioned in the description above are still present after updating from 4.2.0-beta1.

Expected result AFTER applying this Pull Request

All files and folders mentioned in the description above have been deleted after updating from 4.2.0-beta1.

Documentation Changes Required

None.

@sandewt
Copy link
Contributor

sandewt commented Jun 13, 2022

I have tested this item ✅ successfully on 189027b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039.

@richard67
Copy link
Member Author

@sandewt Thanks for your test. Unfortunately it doesn't make much sense since this PR is in draft status and clearly marked as WiP (work in progress) in the title and the description because there might be more PRs merged into 4.2-dev before the next beta release and so more files have to be added to this PR here. So I suggest to wait with testing until the PR is ready (not draft anymore). But very likely the release leads will merge it by review when time has come.

@sandewt
Copy link
Contributor

sandewt commented Jun 13, 2022

@richard67

I will wait 😃

@richard67 richard67 marked this pull request as ready for review June 19, 2022 17:47
@richard67 richard67 changed the title [4.2] [WiP] Update deleted files and folders for 4.2.0-beta2 [4.2] Update deleted files and folders for 4.2.0-beta2 Jun 19, 2022
@richard67
Copy link
Member Author

@sandewt The PR is ready now. So if you still can find the time for testing, it would be welcome.

@richard67
Copy link
Member Author

Ping @roland-d .

@sandewt
Copy link
Contributor

sandewt commented Jun 20, 2022

I have tested this item ✅ successfully on a59ef13

Code review.

Done

Or if you want to make a real test, update a 4.2.0-beta1 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-beta1 to the update package built by Drone for this PR to get the expected result.

Done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039.

@richard67
Copy link
Member Author

@sandewt Thanks.

@roland-d roland-d merged commit 8806607 into joomla:4.2-dev Jun 20, 2022
@roland-d
Copy link
Contributor

Thank you

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 20, 2022
@richard67 richard67 deleted the 4.2-dev-update-deleted-files-and-folders-for-beta-2 branch June 20, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants