-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Update deleted files and folders for 4.2.0-beta2 #38039
[4.2] Update deleted files and folders for 4.2.0-beta2 #38039
Conversation
I have tested this item ✅ successfully on 189027b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039. |
@sandewt Thanks for your test. Unfortunately it doesn't make much sense since this PR is in draft status and clearly marked as WiP (work in progress) in the title and the description because there might be more PRs merged into 4.2-dev before the next beta release and so more files have to be added to this PR here. So I suggest to wait with testing until the PR is ready (not draft anymore). But very likely the release leads will merge it by review when time has come. |
I will wait 😃 |
@sandewt The PR is ready now. So if you still can find the time for testing, it would be welcome. |
Ping @roland-d . |
I have tested this item ✅ successfully on a59ef13
Done
Done This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039. |
@sandewt Thanks. |
Thank you |
Pull Request for Issue # .
Summary of Changes
Update the lists of files and folders to be deleted on update by script.php to the latest changes in the 4.2-dev branch in preparation of the upcoming 4.2.0 Beta 2.
Following files and folder from following PR's are included (note that this includes the old location of moved files):
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.2.0-beta1 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-beta1 to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
Files and folders mentioned in the description above are still present after updating from 4.2.0-beta1.
Expected result AFTER applying this Pull Request
All files and folders mentioned in the description above have been deleted after updating from 4.2.0-beta1.
Documentation Changes Required
None.