[SYCL] Host task implementation #1471

s-kanaev · 2020-04-03T13:19:54Z

This patch is part 1 in a series of patches for host-interop-task proposal by
Codeplay. See the proposal at [1].

This patch implements:

host-task execution mechanism;
enqueue of host-task without interop_handle argument;
spin-lock to await for host and synchronous device events completion.

This patch reimplements glue/connection of events within different contexts to
eliminate use of event callback in favor of host-task.

Host-task execution mechanism involves:

thread-pool for queue to execute host-task's user lambda in;
explicit call to event_impl::setComplete() for host events and device-side
synchronous events;
helper class DispatchHostTask which wraps call to host-task's user lambda.

Thread pool's size is set via SYCL_QUEUE_THREAD_POOL_SIZE environment variable
and defaults to 1.

Even though host-task is enqueued to device queue it'll be executed on the
default host queue.
Host-task is represented via distinct ExecCGCommand paired with EmptyCommand.
Any other command, which depends on host-task will really depend on it's
EmptyCommand. The EmptyCommand is in blocked state initially.

Class DispatchHostTask awaits for host-task's dependency events, then calls to
host-task's user lambda and unblocks any dependent commands via unblocking it's
EmptyCommand and enqueueing of leaves for requirements (i.e. host accessors
required for execution of this host-task).

[1] https://github.com/codeplaysoftware/standards-proposals/blob/master/host_task/host_task.md

Signed-off-by: Sergey Kanaev <[email protected]>

sycl/source/detail/scheduler/graph_builder.cpp

Signed-off-by: Sergey Kanaev <[email protected]>

s-kanaev · 2020-05-19T11:08:24Z

@keryell Somehow, I can't re-request review with github's UI, so, please, review and approve.

romanovvlad · 2020-05-20T08:07:02Z

@s-kanaev Please, provide a final commit message for this PR.

s-kanaev · 2020-05-20T08:14:24Z

Please, provide a final commit message for this PR.

Done.

* sycl: (65 commits) [SYCL] Host task implementation (intel#1471) [SYCL] Update getting dependencies documentation (intel#1699) [SYCL] Fix types and transparent functors recognition in reduction (intel#1709) [SYCL][Doc] Get started guide clean-up (intel#1697) Add --spirv-fp-contract={on|off|fast} option (intel#509) [SYCL][Doc] Fix tbb target path in Get Started Guide. (intel#1695) [SYCL] Add support for kernel name types templated using enums. (intel#1675) [Driver][SYCL] Make -std=c++17 the default for DPC++ (intel#1662) AllocaInst should store Align instead of MaybeAlign. [X86] Replace selectScalarSSELoad ComplexPattern with PatFrags to handle the 3 types of loads we currently match. Harden IR and bitcode parsers against infinite size types. Revert "[nfc] test commit" [nfc] test commit Expose IRGen API to add the default IR attributes to a function definition. The release notes for ObjCBreakBeforeNestedBlockParam was placed between the release note for IndentCaseBlocks and its example code [VectorCombine] forward walk through instructions to improve chaining of transforms [PhaseOrdering] add vector reduction tests; NFC [InstCombine] Clean up alignment handling (NFC) [ARM] Patterns for VQSHRN [VectorCombine] add reduction-like patterns; NFC ...

Since introduction of host tasks in #1471, `piEventCallback` and related functionality is not required by the SYCL-RT. Removing the implementation of this behaviour from the CUDA backend simplifies the submission of operations to streams and overall increases performance. Signed-off-by: Ruyman Reyes <[email protected]>

s-kanaev · 2020-06-25T08:54:29Z

sycl/test/host-interop-task/host-task-two-queues.cpp

+    auto AccA = BufA.get_access<sycl::access::mode::read>(CGH);
+    auto AccB = BufB.get_access<sycl::access::mode::read>(CGH);
+    auto AccC = BufC.get_access<sycl::access::mode::read_write>(CGH);


Need to have host accessor, not device-one.

The tests provided here are for the fix introduced with #1471. Use case fixed by the fix. Imagine us having two device queues (`Q1` and `Q2`) and a single buffer `B`. We initialize the buffer with host accessor. Also lets have two kernels: kernel `K1` executed at `Q1`; and kernel `K2` which executes at `Q2`. `K1` writes to `B`, `K2` reads from `B`. After submitting `K1` to `Q1` there will also be an `AllocaCommand` `A1` which allocates buffer on device. `K1` depends on `A1` via memory object `B`. After submitting `K2` to `Q2` there will be another `AllocaCommand` `A2` (for queue `Q2` and its device). `K2` will depend on `A2`. `A2`, however, should depend on both `A1` and `K1`. `A2->K1` dependency eliminates data race. Signed-off-by: Sergey Kanaev <[email protected]>

Sergey Kanaev added 30 commits March 4, 2020 14:42

[SYCL] Allow for creating host accessor without blocked event.

b31cb8e

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Tests for host/interop task

f3bf37a

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Remove unused parameter

faded84

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Some syntax improvements

253086f

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Sample impl of host task through event

cacb056

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/interop-task

37106ea

[SYCL] Sample implementation without OpenCL specific calls.

1a79e3f

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/interop-task

9057a23

[SYCL] Only leave event-callback

93cffcc

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Fix typo

3790b3a

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

4255434

[SYCL] Allow for running lit-tests with threads.

dc0ab02

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

0d95eaa

[SYCL] A more sophisticated thread pool impl

f0df349

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Proper use of fork() in assertion test

ea577f6

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Fix style issue

99f64fb

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

9c8b1a1

[SYCL] Fix some typos. Lazy initialization of thread pool.

529d4dc

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Employ event::when_complete instead of piEventSetCallback

4d04655

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Host-task test

1e3bfe4

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Remove unwanted include

fc70b03

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

1429f9d

[SYCL] Worked on host-task

eaaefd3

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

1172ca1

[SYCL] Reimplement event::when_complete through host_task

9f3d2d4

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Worked on host task

92917a0

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

578d422

[SYCL] Fix merge issue

8e3dcd8

Signed-off-by: Sergey Kanaev <[email protected]>

Merge branch 'sycl' into private/s-kanaev/event-callback

2c2c713

[SYCL] Fix assert test

14458e3

Signed-off-by: Sergey Kanaev <[email protected]>

Ruyk previously approved these changes May 15, 2020

View reviewed changes

romanovvlad requested changes May 18, 2020

View reviewed changes

Sergey Kanaev added 5 commits May 18, 2020 14:09

Merge branch 'sycl' into private/s-kanaev/event-callback

90f73c4

[SYCL] Eliminate for-loop whilst constructing deps of connect-cmd

b4ab2f2

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Reword construction of a vector

64d6ba8

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Reword comments

692bf79

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Eliminate const_cast

6f3b4d7

Signed-off-by: Sergey Kanaev <[email protected]>

s-kanaev dismissed Ruyk’s stale review via 6f3b4d7 May 18, 2020 14:19

s-kanaev requested review from romanovvlad and Ruyk May 18, 2020 14:20

Sergey Kanaev added 2 commits May 18, 2020 17:28

[SYCL] Fix style issues

5d2635b

Signed-off-by: Sergey Kanaev <[email protected]>

[SYCL] Fix style issues

efd1495

Signed-off-by: Sergey Kanaev <[email protected]>

romanovvlad approved these changes May 18, 2020

View reviewed changes

s-kanaev requested a review from dm-vodopyanov May 19, 2020 11:12

s-kanaev mentioned this pull request May 19, 2020

[SYCL] Interop-part of host task #1710

Closed

3 tasks

pvchupin approved these changes May 19, 2020

View reviewed changes

bader merged commit ae3fd5c into intel:sycl May 20, 2020

Ruyk mentioned this pull request May 21, 2020

[SYCL][CUDA] Remove pi Event Callback implementation #1735

Merged

s-kanaev mentioned this pull request Jun 17, 2020

[SYCL] Test for fix of linked alloca's deps #1470

Merged

s-kanaev commented Jun 25, 2020

View reviewed changes

iburyl mentioned this pull request Jul 7, 2020

[SYCL] Host task accessor deduction guides #2055

Merged

s-kanaev deleted the private/s-kanaev/event-callback branch September 2, 2020 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] Host task implementation #1471

[SYCL] Host task implementation #1471

s-kanaev commented Apr 3, 2020 •

edited

Loading

s-kanaev commented May 19, 2020

romanovvlad commented May 20, 2020

s-kanaev commented May 20, 2020

s-kanaev Jun 25, 2020

[SYCL] Host task implementation #1471

[SYCL] Host task implementation #1471

Conversation

s-kanaev commented Apr 3, 2020 • edited Loading

s-kanaev commented May 19, 2020

romanovvlad commented May 20, 2020

s-kanaev commented May 20, 2020

s-kanaev Jun 25, 2020

Choose a reason for hiding this comment

s-kanaev commented Apr 3, 2020 •

edited

Loading