Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Host task accessor deduction guides #2055

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Conversation

iburyl
Copy link
Contributor

@iburyl iburyl commented Jul 7, 2020

This patch adds host task functionality of SYCL_INTEL_accessor_simplification extension.

handler type is now valid argument for host_accessor and buffer.get_host_access(), which enables non-blocking behavior, while accessing memory on the host.

Related PR: #1943 and #1471

iburylov added 2 commits July 6, 2020 18:25
@iburyl iburyl requested a review from a team as a code owner July 7, 2020 08:53
@iburyl iburyl requested a review from rbegam July 7, 2020 08:53
Signed-off-by: iburylov <[email protected]>
@iburyl iburyl changed the title Host task accessor deduction guides [SYCL] Host task accessor deduction guides Jul 7, 2020
@iburyl
Copy link
Contributor Author

iburyl commented Jul 9, 2020

@rbegam, any comments?

@s-kanaev, can you have quick look - I've allowed more accessor ctors for host tasks.

@sergey-semenov, you looked through previous PRs in this set, do you have concerns for this PR?

Copy link
Contributor

@rbegam rbegam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader requested a review from sergey-semenov July 13, 2020 15:42
@bader bader merged commit 43af08d into intel:sycl Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants