[SYCL][CUDA] Remove pi Event Callback implementation #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since introduction of host tasks in #1471, `piEventCallback` and related functionality is not required by the SYCL-RT. Removing the implementation of this behaviour from the CUDA backend simplifies the submission of operations to streams and overall increases performance. Signed-off-by: Ruyman Reyes <[email protected]>
|
@StuartDAdams / @steffenlarsen please take a look , this is basically reverting your original work on callbacks! |
|
It is glorious. Good riddance. |
nyalloc
reviewed
May 21, 2020
sycl/plugins/cuda/pi_cuda.cpp
Outdated
| PI_CHECK_ERROR(cuEventCreate(&evEnd_, CU_EVENT_DEFAULT)); | ||
|
|
||
| if (queue_->properties_ & PI_QUEUE_PROFILING_ENABLE) { | ||
| PI_CHECK_ERROR(cuEventCreate(&evQueued_, CU_EVENT_DEFAULT)); | ||
| PI_CHECK_ERROR(cuEventCreate(&evStart_, CU_EVENT_DEFAULT)); | ||
| } | ||
| } else { | ||
| cl::sycl::detail::pi::die("User-defined events not implemented"); |
There was a problem hiding this comment.
Would be good to give more granular message so that the user knows this error is coming from the CUDA backend. Same comment on line 2709.
|
LGTM! |
|
@Ruyk some cuda tests are failing, please fix. |
|
The test failures don't seem to be caused by this PR. I have made a separate PR to fix the tests: #1763 |
Any ideas how this test failure might be introduced? I thought that buildbot check should had caught such regressions. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 2, 2020
* upstream/sycl: [SYCL] Handle KernelName templated using type with enum template argument (intel#1780) [SYCL] Fix KernelNameInfo generated for empty template parameter pack (intel#1775) [SYCL] Do not export utility methods from SYCLMemObjT (intel#1768) [Driver][SYCL] Fix processing when using -fsycl-link (intel#1765) [SYCL][NFC] Remove outdated confusing comment (intel#1779) [SYCL][NFC] Wrap classes in .cpp into a namespace to disable external linkage. (intel#1776) [SYCL][CUDA] Fixes CUDA unit tests that uses SYCL directly (intel#1763) [SYCL][Doc] Fix default device selection rules doc (intel#1769) [SYCL][CUDA] Remove pi Event Callback implementation (intel#1735) [SYCL] Throw exception if range/offset of kernel execution exceeds INT_MAX (intel#1713) [SYCL-PTX] Add intermediate layer to libclc to ease type management (intel#1712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since introduction of host tasks in #1471,
piEventCallbackand related functionality is not required by the SYCL-RT.Removing the implementation of this behaviour from the CUDA backend simplifies the submission of operations to streams and increases performance in multiple benchmarks.
Signed-off-by: Ruyman Reyes [email protected]