[SYCL] Fix types and transparent functors recognition in reduction #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
force-pushed
the
public_vklochkov_reduction_p5ctor
branch
from
410d960
to
b5909e4
Compare
1. Enable operator*, operator+, operator|, operator&, operator^= for corresponding transparent functors used in reduction. 2. Fixed the case when reduction object is passed to parallel_for an R-value. 3. Allow identity-less constructors for reductions with transparent functors. 4. Replaced some 'auto' declarations with Reduction::result_type and added intermediate assignments/casts to avoid type ambiguities caused by using sycl::half type, and which may also be caused by custom/user types as well. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_reduction_p5ctor
branch
from
b5909e4
to
65c378e
Compare
Pennycook
requested changes
May 19, 2020
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Pennycook
approved these changes
May 19, 2020
alexbatashev
approved these changes
May 19, 2020
s-kanaev
reviewed
May 20, 2020
s-kanaev
approved these changes
May 20, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
May 20, 2020
* sycl: (65 commits) [SYCL] Host task implementation (intel#1471) [SYCL] Update getting dependencies documentation (intel#1699) [SYCL] Fix types and transparent functors recognition in reduction (intel#1709) [SYCL][Doc] Get started guide clean-up (intel#1697) Add --spirv-fp-contract={on|off|fast} option (intel#509) [SYCL][Doc] Fix tbb target path in Get Started Guide. (intel#1695) [SYCL] Add support for kernel name types templated using enums. (intel#1675) [Driver][SYCL] Make -std=c++17 the default for DPC++ (intel#1662) AllocaInst should store Align instead of MaybeAlign. [X86] Replace selectScalarSSELoad ComplexPattern with PatFrags to handle the 3 types of loads we currently match. Harden IR and bitcode parsers against infinite size types. Revert "[nfc] test commit" [nfc] test commit Expose IRGen API to add the default IR attributes to a function definition. The release notes for ObjCBreakBeforeNestedBlockParam was placed between the release note for IndentCaseBlocks and its example code [VectorCombine] forward walk through instructions to improve chaining of transforms [PhaseOrdering] add vector reduction tests; NFC [InstCombine] Clean up alignment handling (NFC) [ARM] Patterns for VQSHRN [VectorCombine] add reduction-like patterns; NFC ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding transparent functors used in reduction.
an R-value.
and added intermediate assignments/casts to avoid type ambiguities
caused by using sycl::half type, and which may also be caused by custom/user
types as well.
Signed-off-by: Vyacheslav N Klochkov [email protected]