3 to 6 #743
Merged
3 to 6 #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Crola1702 <[email protected]> Signed-off-by: Crola1702 <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* Improved coverage Arrow and Axis visuals and fixed some warnings Signed-off-by: ahcorde <[email protected]>
* Improved coverage Grid
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #743 +/- ##
==================================================
+ Coverage 77.41% 77.82% +0.41%
==================================================
Files 146 146
Lines 13397 13397
==================================================
+ Hits 10371 10426 +55
+ Misses 3026 2971 -55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
reviewed
Oct 14, 2022
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (C) 2020 Open Source Robotics Foundation | |||
| * Copyright (C) 2022 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
how about keeping the original copyright year? I think #736 backported this class to citadel and changed to date to 2022. So we can just keep the original year when forward porting?
There was a problem hiding this comment.
I had the same issue in common, though I don't think I fixed the copyright years...
iche033
reviewed
Oct 14, 2022
iche033
approved these changes
Oct 14, 2022
Signed-off-by: ahcorde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-rendering3 to ign-rendering6
Branch comparison: ign-rendering6...ign-rendering3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)