Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved grid coverage #737

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Improved grid coverage #737

merged 3 commits into from
Oct 12, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 12, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Related with gazebosim/gz-sim#1575

Improved grid coverage

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Oct 12, 2022
@ahcorde ahcorde requested a review from iche033 as a code owner October 12, 2022 20:03
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #737 (4c978fd) into ign-rendering3 (4a364a2) will increase coverage by 0.46%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering3     #737      +/-   ##
==================================================
+ Coverage           76.42%   76.88%   +0.46%     
==================================================
  Files                 100      100              
  Lines                7805     7805              
==================================================
+ Hits                 5965     6001      +36     
+ Misses               1840     1804      -36     
Impacted Files Coverage Δ
ogre2/src/Ogre2DynamicRenderable.cc 52.95% <0.00%> (+3.73%) ⬆️
ogre2/src/Ogre2Grid.cc 97.40% <0.00%> (+31.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit d4d071b into ign-rendering3 Oct 12, 2022
@ahcorde ahcorde deleted the ahcorde/3/coverage/grid branch October 12, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants