Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport from 6 ➡️ 3 - Disable C4275 warnings on Windows from OgreUTFString (#621) #707

Merged

Conversation

Crola1702
Copy link
Contributor

Backports #617

Reference issue: #621

Signed-off-by: Crola1702 [email protected]

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Backport

Port 6 to 3

Branch comparison: ign-rendering3...Crola1702:Crola1702/6_to_3-2022_08_16

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Crola1702 <[email protected]>
@Crola1702 Crola1702 requested a review from iche033 as a code owner August 16, 2022 16:11
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #707 (9cf809e) into ign-rendering3 (d82ba31) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering3     #707   +/-   ##
===============================================
  Coverage           75.37%   75.37%           
===============================================
  Files                  98       98           
  Lines                7793     7793           
===============================================
  Hits                 5874     5874           
  Misses               1919     1919           
Impacted Files Coverage Δ
ogre2/src/Ogre2RenderEngine.cc 78.80% <ø> (ø)
ogre2/src/Ogre2RenderTarget.cc 72.46% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina added Windows Windows support QA Quality assurance. labels Aug 16, 2022
@chapulina chapulina merged commit 84724f5 into gazebosim:ign-rendering3 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance. Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants