Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved coverage Arrow and Axis visuals and fixed some warnings #736

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 12, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Related with gazebosim/gz-sim#1575

Improved coverage Arrow and Axis visuals and fixed some warnings

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Oct 12, 2022
@ahcorde ahcorde requested a review from iche033 as a code owner October 12, 2022 19:44
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #736 (a4c3a5a) into ign-rendering3 (84724f5) will increase coverage by 1.05%.
The diff coverage is 100.00%.

❗ Current head a4c3a5a differs from pull request most recent head 9d4a36c. Consider uploading reports for the commit 9d4a36c to get more accurate results

@@                Coverage Diff                 @@
##           ign-rendering3     #736      +/-   ##
==================================================
+ Coverage           75.37%   76.42%   +1.05%     
==================================================
  Files                  98      100       +2     
  Lines                7793     7805      +12     
==================================================
+ Hits                 5874     5965      +91     
+ Misses               1919     1840      -79     
Impacted Files Coverage Δ
include/ignition/rendering/base/BaseArrowVisual.hh 100.00% <100.00%> (+100.00%) ⬆️
ogre2/src/Ogre2ArrowVisual.cc 100.00% <100.00%> (ø)
ogre2/src/Ogre2AxisVisual.cc 100.00% <100.00%> (ø)
ogre2/src/Ogre2Scene.cc 89.84% <100.00%> (+2.28%) ⬆️
src/base/BaseScene.cc 75.89% <0.00%> (+4.89%) ⬆️
include/ignition/rendering/AxisVisual.hh 100.00% <0.00%> (+100.00%) ⬆️
include/ignition/rendering/ArrowVisual.hh 100.00% <0.00%> (+100.00%) ⬆️
include/ignition/rendering/CompositeVisual.hh 100.00% <0.00%> (+100.00%) ⬆️
include/ignition/rendering/base/BaseAxisVisual.hh 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit 4a364a2 into ign-rendering3 Oct 12, 2022
@ahcorde ahcorde deleted the ahcorde/3/coverage/arrow_axis branch October 12, 2022 21:28
@iche033 iche033 mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants