Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.53.0 to 0.54.0 #371

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

dependabot-preview[bot]
Copy link

@dependabot-preview dependabot-preview bot commented Mar 21, 2018

Bumps rubocop from 0.53.0 to 0.54.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.54

New features

Bug fixes

  • #5683: Fix message for Naming/UncommunicativeXParamName cops. ([jlfaber][])
  • #5680: Fix Layout/ElseAlignment for rescue/else/ensure inside do/end blocks. ([YukiJikumaru][])
  • #5642: Fix Style/Documentation :nodoc: for compact-style nested modules/classes. ([ojab][])
  • #5648: Suggest valid memoized instance variable for predicate method. ([satyap][])
  • #5670: Suggest valid memoized instance variable for bang method. ([pocke][])
  • #5623: Fix Bundler/OrderedGems when a group includes duplicate gems. ([colorbox][])
  • #5633: Fix broken --fail-fast. ([mmyoji][])
  • #5630: Fix false positive for Style/FormatStringToken when using placeholder arguments in format method. ([koic][])
  • #5651: Fix NoMethodError when specified config file that does not exist. ([onk][])
  • #5647: Fix encoding method of RuboCop::MagicComment::SimpleComment. ([htwroclau][])
  • #5619: Do not register an offense in Style/InverseMethods when comparing constants with <, >, <=, or >=. If the code is being used to determine class hierarchy, the correction might not be accurate. ([rrosenblum][])
  • #5641: Disable Style/TrivialAccessors auto-correction for def with private. ([pocke][])
  • Fix bug where Style/SafeNavigation does not auto-correct all chained methods resulting in a Lint/SafeNavigationChain offense. ([rrosenblum][])
  • #5436: Allow empty kwrest args in UncommunicativeName cops. ([pocke][])
  • #5674: Fix auto-correction of Layout/EmptyComment when the empty comment appears on the same line as code. ([rrosenblum][])
  • #5679: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before rescue or ensure. ([koic][])
  • #5694: Match Rails versions with multiple digits when reading the TargetRailsVersion from the bundler lock files. ([roberts1000][])
  • #5700: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before else. ([koic][])
  • Fix false positive in Naming/ConstantName when using conditional assignment. ([drenmi][])

Changes

  • #5626: Change Naming/UncommunicativeMethodParamName add to to allowed names in default config. ([unused][])
  • #5640: Warn about user configuration overriding other user configuration only with --debug. ([jonas054][])
  • #5637: Fix error for Layout/SpaceInsideArrayLiteralBrackets when contains an array literal as an argument after a heredoc is started. ([koic][])
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. ([hamada14][])
  • #5610: Use gems.locked or Gemfile.lock to determine the best TargetRubyVersion when it is not specified in the config. ([roberts1000][])
  • #5390: Allow exceptions to Style/InlineComment for inline comments which enable or disable rubocop cops. ([jfelchner][])
  • Add progress bar to offenses formatter. ([drewpterry][])
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. ([hamada14][])

[anthony-robin]: https://github.com/anthony-robin
[bdewater]: https://github.com/bdewater
[jlfaber]: https://github.com/jlfaber
[YukiJikumaru]: https://github.com/YukiJikumaru
[ojab]: https://github.com/ojab
[satyap]: https://github.com/satyap
[pocke]: https://github.com/pocke
[colorbox]: https://github.com/colorbox
[mmyoji]: https://github.com/mmyoji
[koic]: https://github.com/koic
[onk]: https://github.com/onk
... (truncated)

Changelog

Sourced from rubocop's changelog.

0.54.0 (2018-03-21)

New features

Bug fixes

  • #5683: Fix message for Naming/UncommunicativeXParamName cops. ([jlfaber][])
  • #5680: Fix Layout/ElseAlignment for rescue/else/ensure inside do/end blocks. ([YukiJikumaru][])
  • #5642: Fix Style/Documentation :nodoc: for compact-style nested modules/classes. ([ojab][])
  • #5648: Suggest valid memoized instance variable for predicate method. ([satyap][])
  • #5670: Suggest valid memoized instance variable for bang method. ([pocke][])
  • #5623: Fix Bundler/OrderedGems when a group includes duplicate gems. ([colorbox][])
  • #5633: Fix broken --fail-fast. ([mmyoji][])
  • #5630: Fix false positive for Style/FormatStringToken when using placeholder arguments in format method. ([koic][])
  • #5651: Fix NoMethodError when specified config file that does not exist. ([onk][])
  • #5647: Fix encoding method of RuboCop::MagicComment::SimpleComment. ([htwroclau][])
  • #5619: Do not register an offense in Style/InverseMethods when comparing constants with <, >, <=, or >=. If the code is being used to determine class hierarchy, the correction might not be accurate. ([rrosenblum][])
  • #5641: Disable Style/TrivialAccessors auto-correction for def with private. ([pocke][])
  • Fix bug where Style/SafeNavigation does not auto-correct all chained methods resulting in a Lint/SafeNavigationChain offense. ([rrosenblum][])
  • #5436: Allow empty kwrest args in UncommunicativeName cops. ([pocke][])
  • #5674: Fix auto-correction of Layout/EmptyComment when the empty comment appears on the same line as code. ([rrosenblum][])
  • #5679: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before rescue or ensure. ([koic][])
  • #5694: Match Rails versions with multiple digits when reading the TargetRailsVersion from the bundler lock files. ([roberts1000][])
  • #5700: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before else. ([koic][])
  • Fix false positive in Naming/ConstantName when using conditional assignment. ([drenmi][])

Changes

  • #5626: Change Naming/UncommunicativeMethodParamName add to to allowed names in default config. ([unused][])
  • #5640: Warn about user configuration overriding other user configuration only with --debug. ([jonas054][])
  • #5637: Fix error for Layout/SpaceInsideArrayLiteralBrackets when contains an array literal as an argument after a heredoc is started. ([koic][])
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. ([hamada14][])
  • #5610: Use gems.locked or Gemfile.lock to determine the best TargetRubyVersion when it is not specified in the config. ([roberts1000][])
  • #5390: Allow exceptions to Style/InlineComment for inline comments which enable or disable rubocop cops. ([jfelchner][])
  • Add progress bar to offenses formatter. ([drewpterry][])
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. ([hamada14][])
Commits
  • 3323d94 Cut 0.54
  • 3934b2c Improve a bit the changelog markup
  • ee53ffd Remove unnecessary condition in rubocop.gemspec
  • 0a20cb9 Fix false positive for Style/EmptyLineAfterGuardClause (#5700)
  • 8a1f595 Prevent false positive in Naming/ConstantName when using conditional assignment
  • f78a4e0 Add 'Style/UnpackFirst' cop
  • 902491c [Fix #5694] Match Rails versions with multiple digits
  • 862a594 [#5390] Allow exceptions to Style/InlineComment for RuboCop comments (#5697)
  • 3f81a25 Add progress bar to offense formatter (#5675)
  • f7f2104 Fix build error in project_spec.rb
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-0.54.0 branch from 33a2abc to 9946724 Compare March 21, 2018 06:11
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-0.54.0 branch from 9946724 to 056ea7d Compare March 21, 2018 06:20
@davidwessman davidwessman merged commit fd4f211 into master Mar 21, 2018
@davidwessman davidwessman deleted the dependabot/bundler/rubocop-0.54.0 branch March 21, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants