Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Style/InlineComment Exception for Rubocop Comments #5390

Closed
jfelchner opened this issue Jan 4, 2018 · 1 comment
Closed

Comments

@jfelchner
Copy link
Contributor

jfelchner commented Jan 4, 2018

In general I like to avoid inline comments (obviously with some exceptions), but when I attempted to try out this cop, I ran into a huge hurdle.

Rubocop uses inline comments to disable certain cops. This is a useful feature as it doesn't require re-enabling the cop on the next line.

Unfortunately, because the InlineComment cop doesn't provide an exception for rubocop comments, it requires every Rubocop inline comment to also require disabling the InlineComment cop.

bbatsov pushed a commit that referenced this issue Mar 18, 2018
…5697)

Previously if InlineComment was enabled, any RuboCop inline comments
which disabled a cop would require also disabling the InlineComment cop.
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
@jfelchner
Copy link
Contributor Author

Implemented here: #5697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants