Fix broken --fail-fast
#5633
Merged
Fix broken --fail-fast
#5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Can you please add a changelog entry as well? |
|
@bbatsov thank you for your review! I added a changelog in the last commit 😄 |
|
Thanks for the first time contribution. It seems that CI has failure. That will be resolved by adding your account at the end of CHANGELOG.md. When you are finished, please squash multiple commits in PR into 1 commit. |
Add lacked `--fail-fast` test at minimum as well
|
@koic I fixed the CHANGELOG.md and rebased the commits into a single one 👍 Thank you for your help 🙌 |
|
👍 |
|
👍 |
|
Are there any plans to release it? |
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocop --fail-fastwas broken at 43a157fI fixed this and add minimum test for it.