Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Rails versions with multiple digits when reading bundler lock files #5694

Closed
roberts1000 opened this issue Mar 16, 2018 · 0 comments
Closed

Comments

@roberts1000
Copy link
Contributor

roberts1000 commented Mar 16, 2018

This regex in the implementation for #5473 won't match correctly when the Rails version has parts with multiple digits. For example, the regex won't match Rails 10.0.0 or 5.10.0 correct. This isn't a big issue now, but it'll cause problems eventually.

@roberts1000 roberts1000 changed the title Match Rails versions with multiple digits when reading the lock files Match Rails versions with multiple digits when reading bundler lock files Mar 16, 2018
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant