Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate message for Naming/Uncommunicative<x>ParamName #5683

Closed
jlfaber opened this issue Mar 14, 2018 · 0 comments
Closed

Inaccurate message for Naming/Uncommunicative<x>ParamName #5683

jlfaber opened this issue Mar 14, 2018 · 0 comments

Comments

@jlfaber
Copy link
Contributor

jlfaber commented Mar 14, 2018

The current message is <x> parameter must be longer than <n> characters.

This is inaccurate because the names must be at least n characters long, not longer than that.

For example, if the method param name min is set to 3 (the default), using a name like xx will result in the cop message Method parameter must be longer than 3 characters. But, in fact, names like arg and foo are acceptable even though they are not longer than 3 characters.

I suggest changing the message to <x> parameter must be at least <n> characters long.


RuboCop version

$ rubocop -V
0.53.0 (using Parser 2.5.0.4, running on ruby 2.5.0 x86_64-darwin16)
jlfaber pushed a commit to jlfaber/rubocop that referenced this issue Mar 15, 2018
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant