-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inaccurate message for Naming/Uncommunicative<x>ParamName #5683
Comments
jlfaber
pushed a commit
to jlfaber/rubocop
that referenced
this issue
Mar 15, 2018
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current message is
<x> parameter must be longer than <n> characters.
This is inaccurate because the names must be at least n characters long, not longer than that.
For example, if the method param name min is set to 3 (the default), using a name like
xx
will result in the cop messageMethod parameter must be longer than 3 characters.
But, in fact, names likearg
andfoo
are acceptable even though they are not longer than 3 characters.I suggest changing the message to
<x> parameter must be at least <n> characters long.
RuboCop version
The text was updated successfully, but these errors were encountered: