Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5390] Allow exceptions to Style/InlineComment for Rubocop comments #5697

Merged
merged 2 commits into from
Mar 18, 2018
Merged

[#5390] Allow exceptions to Style/InlineComment for Rubocop comments #5697

merged 2 commits into from
Mar 18, 2018

Conversation

jfelchner
Copy link
Contributor

Previously if InlineComment was enabled, any Rubocop inline comments
which disabled a cop would require also disabling the InlineComment cop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

jfelchner and others added 2 commits March 17, 2018 19:03
Previously if InlineComment was enabled, any Rubocop inline comments
which disabled a cop would require also disabling the InlineComment cop.
@bbatsov bbatsov merged commit 862a594 into rubocop:master Mar 18, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 18, 2018

Thanks for working on this! I really appreciate it! 🙇

This was referenced Mar 19, 2018
This was referenced Mar 21, 2018
@jfelchner jfelchner deleted the feature/inline-comment-exception-for-rubocop branch April 23, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants