Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UX server side code out of APM UI #454

Closed
18 of 19 tasks
shahzad31 opened this issue Feb 10, 2022 · 8 comments
Closed
18 of 19 tasks

Move UX server side code out of APM UI #454

shahzad31 opened this issue Feb 10, 2022 · 8 comments
Assignees

Comments

@shahzad31
Copy link

shahzad31 commented Feb 10, 2022

We still have node server side code in the APM UI for user experience app, we need to move that out of APM UI.

This is a follow up to elastic/kibana#78430

There are two approaches that will be taken to accomplish this.

User exploratory view to replace charts, this will auto remove server side routes and will make charts completely client side.

In cases where we can't use exploratory view, we should use async search api to make calls to Elasticsearch.

EDIT by @justinkambic:

Areas of focus


Additional items:

@paulb-elastic
Copy link

Pushing to 8.3, and the expectation is that the simplest implementation is done for this to get out of the APM UI codebase

@paulb-elastic
Copy link

Moving to 8.4 as these PRs are not being merged on for 8.3

@emilioalvap
Copy link

@shahzad31 @justinkambic Checking percentile component, it seems to be statically declared inside the UX plugin. Can we remove that from the task list or is there anything else that needs migrating here?

@paulb-elastic
Copy link

Mostly done but moving over to 8.5 board where the last remaining item elastic/kibana#135367 will be targeted for.

@emilioalvap
Copy link

Marking as done, last PR was merged into 8.5

@dominiqueclarke
Copy link

dominiqueclarke commented Sep 28, 2022

POST FF Testing:

Did general smoke tests of the UX page on 8.5 local branch via data from oblt-cli.

Looks great, generally, but the browser breakdown and operating system breakdown appears to be broken.

Screen Shot 2022-09-28 at 3 46 16 PM

cc: @justinkambic @emilioalvap

@paulb-elastic
Copy link

Reopening as per @dominiqueclarke's discovery

@emilioalvap
Copy link

Fixed by elastic/kibana#142992.

Moving to Done Done, as @shahzad31 and I have validated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants