Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Dashboard] Migrate page load duration chart out of APM #132970

Merged
merged 21 commits into from
Jul 13, 2022

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented May 25, 2022

Summary

Related to elastic/uptime#454.

Migrates the Page Load Duration and Page Views charts to Exploratory View embeddables, and removes the previously-used routes and associated tests from APM's plugin and test suites.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic self-assigned this May 25, 2022
@justinkambic justinkambic force-pushed the 454/page-load-distribution branch 2 times, most recently from f4a5963 to 392778c Compare June 6, 2022 14:06
@justinkambic justinkambic force-pushed the 454/page-load-distribution branch from 38cc6d2 to 64bd24e Compare June 13, 2022 15:51
@justinkambic justinkambic force-pushed the 454/page-load-distribution branch from 97cbead to 04cb046 Compare June 14, 2022 13:13
@justinkambic justinkambic marked this pull request as ready for review June 14, 2022 17:57
@justinkambic justinkambic requested review from a team as code owners June 14, 2022 17:57
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 14, 2022
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 151 148 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 167.3KB 162.8KB -4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ux 5.8KB 5.7KB -122.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
apm 87 86 -1
ux 11 10 -1
total -2

Total ESLint disabled count

id before after diff
apm 101 100 -1
ux 14 13 -1
total -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@shahzad31 shahzad31 merged commit 27deb07 into elastic:main Jul 13, 2022
@shahzad31 shahzad31 deleted the 454/page-load-distribution branch July 13, 2022 19:44
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants