Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Dashboard] Migrate Page Views chart from APM to Exploratory View Embeddable #134758

Merged
merged 9 commits into from
Jun 28, 2022
Merged

[UX Dashboard] Migrate Page Views chart from APM to Exploratory View Embeddable #134758

merged 9 commits into from
Jun 28, 2022

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Jun 20, 2022 •
edited
Loading

Summary

Related to elastic/uptime#454.

Due to a limitation in Lens we are unable to migrate the page distribution to be an exploratory view embeddable at the moment. In a previous PR I had pushed both migrations in the same patch, this moves the Page View migration to a separate PR to complete that portion of the work.

You can find the original PR here.

@justinkambic justinkambic added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 20, 2022
@justinkambic justinkambic requested review from a team as code owners June 20, 2022 14:54
@justinkambic justinkambic self-assigned this Jun 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinkambic justinkambic mentioned this pull request Jun 20, 2022
Closed
19 tasks
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic justinkambic enabled auto-merge (squash) June 22, 2022 15:58
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Please add a simple e2e test !!

Otherwise looks great !!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 380 381 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 168.4KB 167.7KB -749.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 63.6KB 63.8KB +141.0B
Unknown metric groups

API count

id before after diff
observability 383 384 +1

ESLint disabled line counts

id before after diff
ux 12 11 -1

Total ESLint disabled count

id before after diff
ux 15 14 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit 4e3ef39 into elastic:main Jun 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 28, 2022
@justinkambic justinkambic mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justinkambic @elasticmachine @kibana-ci @sorenlouv @shahzad31 @kibanamachine