Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate client metrics from APM to UX #133322

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Migrate client metrics from APM to UX #133322

merged 2 commits into from
Jun 21, 2022

Conversation

emilioalvap
Copy link
Contributor

Summary

Related to elastic/uptime#454.

Changes:

  • Deleted client metrics route from apm plugin.
  • Migrated unit test to UX plugin.
  • Migrated client metrics query to UX plugin using useEsSearch and DataView.
  • Updated getRumPageLoadTransactionsProjection with a missing terms filter.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@emilioalvap emilioalvap requested review from a team as code owners June 1, 2022 16:20
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@emilioalvap emilioalvap added chore technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jun 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@emilioalvap emilioalvap mentioned this pull request Jun 1, 2022
Closed
19 tasks
sorenlouv
sorenlouv approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilioalvap emilioalvap force-pushed the uptime-454-metrics-migration branch from 46cc19a to 2ca0479 Compare June 6, 2022 16:55
@emilioalvap emilioalvap force-pushed the uptime-454-metrics-migration branch from a1cc7db to 1f44f74 Compare June 19, 2022 16:56
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 146 148 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 163.8KB 165.0KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@emilioalvap emilioalvap merged commit 69e125f into elastic:main Jun 21, 2022
@justinkambic justinkambic self-assigned this Aug 3, 2022
@justinkambic
Copy link
Contributor

Post-FF testing LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@justinkambic justinkambic

Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emilioalvap @elasticmachine @kibana-ci @justinkambic @sorenlouv @shahzad31