Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Dashboard] Move core web vitals query from APM routes to UX plugin #132755

Closed
wants to merge 63 commits into from
Closed

[UX Dashboard] Move core web vitals query from APM routes to UX plugin #132755

wants to merge 63 commits into from

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented May 23, 2022 •
edited
Loading

Summary

Related to #454.

Moves CWV query/fetch logic entirely to UX plugin.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added chore technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels May 23, 2022
@justinkambic justinkambic self-assigned this May 23, 2022
@justinkambic justinkambic mentioned this pull request May 24, 2022
Closed
19 tasks
@justinkambic justinkambic force-pushed the 454/core-web-vitals branch from 534f18c to 2b17109 Compare May 24, 2022 15:09
@justinkambic justinkambic force-pushed the 454/core-web-vitals branch 4 times, most recently from 6da147e to b589d13 Compare June 6, 2022 14:01
@justinkambic justinkambic force-pushed the 454/core-web-vitals branch from b589d13 to 1d53388 Compare June 7, 2022 15:06
efegurkan and others added 6 commits June 7, 2022 17:49
@efegurkan
[Enterprise Search] Remove content plugin for 8.3 release (elastic#13…
1c8f6ff 
…3738)

* Remove content plugin for 8.3 release

* Delete server side plugins

* Remove collection schema

* Fix CI
@justinkambic
Merge branch 'main' into 454/core-web-vitals
4cc7200
@jgowdyelastic
[ML] Tests for get groups endpoint (elastic#133625)
e10f85f 
* [ML] Tests for get groups endpoint

* adding extra calendar

* removing delete index pattern
@mistic @jbudz
docs(NA): adds @kbn/plugin-discovery into ops devdocs (elastic#133632)
25fea16 
* docs(NA): adds @kbn/plugin-discovery into ops devdocs

* chore(NA): update packages/kbn-plugin-discovery/README.mdx

Co-authored-by: Jonathan Budzenski <[email protected]>

Co-authored-by: Jonathan Budzenski <[email protected]>
@CohenIdo
[Cloud Posture] update retention policy and remove score transform co…
7b31be3 
…nfiguration (elastic#133730)
@vadimkibana @kibanamachine
ui_actions_enchanced to /src (elastic#133512)
1b2c58f 
* move ui_actions_enhanced to /src

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* move translations to /src

* fix typescript errors

* update config files

* update ts configs

* fix config path

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <[email protected]>
@justinkambic justinkambic requested review from a team as code owners June 8, 2022 19:58
@justinkambic justinkambic requested a review from a team June 8, 2022 19:58
@justinkambic justinkambic requested review from a team as code owners June 8, 2022 19:58
@justinkambic
Copy link
Contributor Author

Sorry everyone for the pings! I will re-open this one.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 142 144 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 157.6KB 162.1KB +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ux 5.7KB 5.8KB +66.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic mentioned this pull request Jun 8, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees

@justinkambic justinkambic

Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.