Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Dashboard] Move core web vitals query from APM routes to UX plugin #133974

Merged
merged 13 commits into from
Jun 13, 2022

Conversation

justinkambic
Copy link
Contributor

Summary

I closed #132755 in favor of opening a new PR as I accidentally pinged half of engineering. If you'd approved that PR you should feel confident in this one. The only change is the addition of an e2e test.

Related to #454.

Moves CWV query/fetch logic entirely to UX plugin.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 8, 2022
@justinkambic justinkambic requested a review from a team as a code owner June 8, 2022 23:04
@justinkambic justinkambic self-assigned this Jun 8, 2022
@justinkambic justinkambic requested a review from a team as a code owner June 8, 2022 23:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahzad31 shahzad31 enabled auto-merge (squash) June 13, 2022 09:35
@shahzad31 shahzad31 merged commit 34fa750 into elastic:main Jun 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 142 144 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 157.6KB 162.1KB +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ux 5.7KB 5.8KB +66.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2022
@shahzad31 shahzad31 deleted the 454/core-web-vitals branch June 13, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants