-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Migrate long task metric to UX #134711
[UX] Migrate long task metric to UX #134711
Conversation
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
e0af973
to
5414bea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
@emilioalvap or @shahzad31 could you add some testing steps to either the PR or the issue? I'm happy to go through the post-FF testing for this if necessary, just wanna make sure I'll be covering what you expect during my tests. |
@lucasfcosta Sorry about that, updated the summary with testing instructions. |
POST FF Testing looks good ! |
Summary
Related to elastic/uptime#454.
Changes:
Deleted long task metric route from apm plugin.
Refactored long task metric chart to dataView and EsSearch.
Added unit and e2e tests.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
How to test this PR?
8.4
branch locally and point to one ofoblt
clusters.Inspect ES Queries
in Management -> Stack Management.User Experience
.Inspect
menu and check thatUxLongTaskMetrics (/internal/bsearch)
is in the query list.