Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Migrate long task metric to UX #134711

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

emilioalvap
Copy link
Contributor

@emilioalvap emilioalvap commented Jun 19, 2022

Summary

Related to elastic/uptime#454.

Changes:

  • Deleted long task metric route from apm plugin.

  • Refactored long task metric chart to dataView and EsSearch.

  • Added unit and e2e tests.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

How to test this PR?

  • Build 8.4 branch locally and point to one of oblt clusters.
  • Log in and enable Inspect ES Queries in Management -> Stack Management.
  • Navigate to User Experience.
  • Check that metrics are loaded correctly:
    image
  • Click on top right Inspect menu and check that UxLongTaskMetrics (/internal/bsearch) is in the query list.

@emilioalvap emilioalvap added chore Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jun 19, 2022
@emilioalvap emilioalvap requested review from a team as code owners June 19, 2022 15:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilioalvap emilioalvap force-pushed the migrate-long-task-metrics branch from e0af973 to 5414bea Compare June 21, 2022 14:28
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@emilioalvap
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 148 150 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 165.0KB 166.1KB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@emilioalvap emilioalvap merged commit ce02f07 into elastic:main Jun 24, 2022
@lucasfcosta
Copy link
Contributor

@emilioalvap or @shahzad31 could you add some testing steps to either the PR or the issue? I'm happy to go through the post-FF testing for this if necessary, just wanna make sure I'll be covering what you expect during my tests.

@emilioalvap
Copy link
Contributor Author

@lucasfcosta Sorry about that, updated the summary with testing instructions.

@shahzad31
Copy link
Contributor

POST FF Testing looks good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants